From owner-svn-src-head@freebsd.org Wed Aug 15 18:28:41 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FF3C106B67F; Wed, 15 Aug 2018 18:28:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A598D72E70; Wed, 15 Aug 2018 18:28:40 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf1-x442.google.com with SMTP id l9-v6so836255pff.9; Wed, 15 Aug 2018 11:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k4qzuuHoP3t0BCwgxurp8/JplDZayuII5Kw9uRXDSk8=; b=HRhtj5RRa2QIGtU1PTseNhZvOfJqjp05FhuPo9gz9jTNE2/tuCLvJUd06d7WkKmGVv 4Fh7K1T9+Lkedo/O98EZCkFpPnSumTFmc4VuTBrR+idUiC8O7qKm7pNFfD2o3D3c6BxG f4wSDkgiypnjIJD1Ls0wN68V5Co0IxYHMR1isQIzFJ8IYFrbwEHCXdokqynxRJJ5r7p8 z6YISd4qoWlWFXWxClbaRkPbzwfQbKV4ez0ocKtnIAgGb8pFqdm+22sUY69F0Y1N8Vzm rG24SXp4t0LUAOLtwxBZNuBjrG3xBBU4p7x5r/JC9yppzDiiX9l+U9Q6Jzu4YNGVeWBt 1rBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=k4qzuuHoP3t0BCwgxurp8/JplDZayuII5Kw9uRXDSk8=; b=pR9W7BKRaoBs18NA0qNZU8WegwAN5+wp9U3B5hvVPL9b048jQj/aTHjis9bLUjrENn Vz48c7d53RBc72P8VHYMyGq63lWkS0G6cvDA5PQDT60LMCfQ3D5RJ4xtJKC5FNtyJegH fyl66dbjGiheffx8f/fpM8jWIUxab9ZEB07QHBss2NKWu6LjUgKe6QYplvU4sH5x/Hhn bB0AuU4TB1Im7Tyb32m8k2KnsZdoERwUgviSJlaNOnPGbbEbKODMN2DVCqReksnTyPw7 J6MwRrMmEIMsM4lrGt80Drcesp0hPrH6fWFE4RS2a2bKNKZsYN67aTK9RGJF5X02RGfh 7Kgw== X-Gm-Message-State: AOUpUlFRoHQJL8nN7WVL4hMRoCYxSaXIFsDcKRaJBpl8ZjdsM8W65Cre UuzNJNoTCURoZd9HNj7XQzRyyTS2 X-Google-Smtp-Source: AA+uWPz5pL+rzAHGbi0S7vsVy8gYwFoXNi4MbbgsOy6a8AWviqAkZzl9gx2i5/8HC7MA7J2bqTUyxg== X-Received: by 2002:a63:ee56:: with SMTP id n22-v6mr25014227pgk.402.1534357719391; Wed, 15 Aug 2018 11:28:39 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id w13-v6sm21817404pgs.89.2018.08.15.11.28.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 11:28:38 -0700 (PDT) Sender: Mark Johnston Date: Wed, 15 Aug 2018 14:28:35 -0400 From: Mark Johnston To: rgrimes@freebsd.org, Brad Davis Cc: Ravi Pokala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337857 - in head: bin/csh bin/sh etc Message-ID: <20180815182835.GB42216@raichu> References: <1534353535.920234.1475238264.523AA6C6@webmail.messagingengine.com> <201808151731.w7FHV4vv048790@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201808151731.w7FHV4vv048790@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 18:28:41 -0000 On Wed, Aug 15, 2018 at 10:31:04AM -0700, Rodney W. Grimes wrote: > > On Wed, Aug 15, 2018, at 11:17 AM, Ravi Pokala wrote: > > > Brad, > > > > > > -----Original Message----- > > > From: on behalf of Brad Davis > > > > > > Date: 2018-08-15, Wednesday at 09:22 > > > To: , , > > head@freebsd.org> > > > Subject: svn commit: r337857 - in head: bin/csh bin/sh etc > > > > > > > Author: brd > > > > Date: Wed Aug 15 16:22:12 2018 > > > > New Revision: 337857 > > > > URL: https://svnweb.freebsd.org/changeset/base/337857 > > > > > > > > Log: > > > > Fix build after r337849 > > > > > > > > This moves the symlink creation to after where the files are installed. > > > > > > > > This also inverts the shell change so that it only happens if MK_TCSH is on. > > > ... > > > > Modified: head/etc/master.passwd > > > > ============================================================================== > > > > --- head/etc/master.passwd Wed Aug 15 16:16:59 2018 (r337856) > > > > +++ head/etc/master.passwd Wed Aug 15 16:22:12 2018 (r337857) > > > > @@ -1,6 +1,6 @@ > > > > # $FreeBSD$ > > > > # > > > > -root::0:0::0:0:Charlie &:/root:/bin/csh > > > > +root::0:0::0:0:Charlie &:/root:/bin/sh > > > > toor:*:0:0::0:0:Bourne-again Superuser:/root: > > > > daemon:*:1:1::0:0:Owner of many system processes:/root:/usr/sbin/nologin > > > > operator:*:2:5::0:0:System &:/:/usr/sbin/nologin > > > > > > Woah! Changing the root shell wasn't mentioned in the change > > > description, has nothing to do with fixing r337849, and is a *HUGE* POLA > > > violation. At the very least, a change of this magnitude needs public > > > discussion, and even if the community agreed, it would also require an > > > UPDATING message and relnote. > > > > > > Please revert this change to master.passwd immediately. > > > > Hi Ravi, > > > > Please, look closer. It doesn't change what is actually installed in either case, it just inverts the logic. > > Though the end results maybe the same, we now have a sed that > is running in the normal case, is not run in the exception case, > a src file that must be editted to match the distribution file, > etc. I can not express stronly enough how much I object to this. > > I have explained in your diffential that this should actually be > put back as far as inverted, and that actually bin/csh/Makefile > nor bin/sh/Makefile should never even touch etc/master.password, > simply the wrong place to be doing it. This should be in what > ever Makefile installs /etc/master.password an no place else. As a side observation, this kind of editing at build time can break -DNO_ROOT. See PR 209718 for a different example of the same problem. I haven't yet verified that this change has the same issue; my apologies if I'm missing something and there is no problem after all.