From owner-cvs-all  Fri Sep 14  5:31:33 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1068537B405; Fri, 14 Sep 2001 05:31:27 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA07679;
	Fri, 14 Sep 2001 22:31:16 +1000
Date: Fri, 14 Sep 2001 22:30:53 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@delplex.bde.org>
To: Brian Somers <brian@freebsd-services.com>
Cc: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys cdefs.h 
In-Reply-To: <200109141122.f8EBMYd29701@hak.lan.Awfulhak.org>
Message-ID: <20010914221545.G18664-100000@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, 14 Sep 2001, Brian Somers wrote:

> > asmodai     2001/09/14 04:01:10 PDT
> >
> >   Modified files:
> >     sys/sys              cdefs.h
> >   Log:
> >   For old gcc/gcc-based compilers and non gcc compilers make sure to
> >   hide the __attribute__ gcc keyword.
> >
> >   Reviewed and helped by:	peter
> >
> >   Revision  Changes    Path
> >   1.37      +2 -1      src/sys/sys/cdefs.h
>
> It may be better to #define this as something that'll break the
> compile.  Code that uses gcc __attribute__s will probably break badly
> if they're just ignored.

Yes, this change is backward.  It undoes the main part of rev.1.17.
No special #define's are required to correctly break the compiles,
since __attribute__(()) is already a syntax error.

This regression may be related to breakage of lint(1).  lint(1) now
uses a wrong version of cpp, one that pre-defines __GNUC__.  Since lint
is not gcc, this defeats all the __GNUC__ ifdefs in <sys/cdefs.h>.  In
particular, __attributes__'s in important macros like __printflike are
exposed to lint and lint barfs on important headers like <stdio.h> that
expand these macros.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message