From owner-cvs-all@FreeBSD.ORG Sun Aug 24 16:01:29 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 760E0106564A; Sun, 24 Aug 2008 16:01:29 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211]) by mx1.freebsd.org (Postfix) with ESMTP id 255C68FC0A; Sun, 24 Aug 2008 16:01:29 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 9C4CB1CE37; Sun, 24 Aug 2008 18:01:27 +0200 (CEST) Date: Sun, 24 Aug 2008 18:01:27 +0200 From: Ed Schouten To: Robert Watson Message-ID: <20080824160127.GW99951@hoeg.nl> References: <200808241006.m7OA6IbU072333@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9W0zaDh10igqoM3B" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 16:01:29 -0000 --9W0zaDh10igqoM3B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Robert Watson wrote: > Do you plan to provide updated compat libs for 4.x, 5.x, 6.x, 7.x, to=20 > replace libc/libutil code that expects to be able to execute the pt_chown= =20 > binary? What happens if that code can't find the pt_chown binary it=20 > expects? I thought my commit message already explained this: > After some discussions back in June I changed the PTY code to set > permissions properly upon creation. Fortunately the previous grantpt() > implementation changed permissions by hand when pt_chown is not > installed, which always succeeds. This means grantpt() still works > properly, even though the set-uid utility is missing. There is no need for compat libraries, because the existing ones already do this: - Try to run pt_chown. - If that fails, try to chmod/chown the slave device by hand. - If that fails, return an error. Because the PTY that openpty() obtains already has the proper permissions in place, the second step won't fail. --=20 Ed Schouten WWW: http://80386.nl/ --9W0zaDh10igqoM3B Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkixhdcACgkQ52SDGA2eCwUPUACdE8m+gICu9sGz2bmluoCAfEXJ IAwAn27VTMqsBnsL72cbTecU49V7kOQD =0Q1Z -----END PGP SIGNATURE----- --9W0zaDh10igqoM3B--