From owner-p4-projects@FreeBSD.ORG Fri Jun 8 19:26:24 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 299C516A477; Fri, 8 Jun 2007 19:26:24 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D929A16A46B; Fri, 8 Jun 2007 19:26:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 70B3013C4C5; Fri, 8 Jun 2007 19:26:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l58JQIkT059115; Fri, 8 Jun 2007 15:26:18 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Attilio Rao" Date: Fri, 8 Jun 2007 15:25:36 -0400 User-Agent: KMail/1.9.6 References: <200706021756.l52Huq9A049371@repoman.freebsd.org> <200706081351.54281.jhb@freebsd.org> <3bbf2fe10706081100k4f1457f2g6a714d8c897dc395@mail.gmail.com> In-Reply-To: <3bbf2fe10706081100k4f1457f2g6a714d8c897dc395@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200706081525.38380.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 08 Jun 2007 15:26:19 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3380/Fri Jun 8 08:34:26 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Rui Paulo , Perforce Change Reviews , Rui Paulo Subject: Re: PERFORCE change 120788 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2007 19:26:24 -0000 On Friday 08 June 2007 02:00:18 pm Attilio Rao wrote: > 2007/6/8, John Baldwin : > > On Wednesday 06 June 2007 09:31:28 am Attilio Rao wrote: > > > Rui Paulo wrote: > > > > > > > > If I'm not doing something wrong, I need to use spin locks on my > > > > interrupt handler, or else witness_checkorder will complain with > > > > "blockable sleep lock". > > > > > > > > Note that I'm using FILTERs. > > > > > > So you are doing this in the wrong way. > > > In order to use correctly filters, please note that the support for them > > > is compile time choosen, so you need to wrapper all filter specific > > > parts using INTR_FILTER compat macro. > > > > Actually, if you only use a filter and not an ithread handler, you can do that > > now w/o needing to have any #ifdef INTR_FILTER stuff. > > In the case your kernel doesn't use filters (!INTR_FILTER) and you > pass a filter, it is automatically mapped to work as a fast handler? Yes. -- John Baldwin