From owner-freebsd-net@FreeBSD.ORG  Fri May 20 21:49:05 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B32CB16A4CE
	for <freebsd-net@freebsd.org>; Fri, 20 May 2005 21:49:05 +0000 (GMT)
Received: from shuttle.wide.toshiba.co.jp (shuttle.wide.toshiba.co.jp
	[202.249.10.124])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D358543D77
	for <freebsd-net@freebsd.org>; Fri, 20 May 2005 21:49:04 +0000 (GMT)
	(envelope-from jinmei@isl.rdc.toshiba.co.jp)
Received: from ocean.jinmei.org (unknown [2001:4f8:3:bb:bc95:2d64:c352:46ff])
	by shuttle.wide.toshiba.co.jp (Postfix) with ESMTP
	id A56AD15218; Sat, 21 May 2005 06:51:22 +0900 (JST)
Date: Sat, 21 May 2005 06:49:56 +0900
Message-ID: <y7vy8a9lg8r.wl%jinmei@isl.rdc.toshiba.co.jp>
From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?=
	<jinmei@isl.rdc.toshiba.co.jp>
To: snap-users@kame.net
In-Reply-To: <m2k6lxu3s9.wl%gnn@neville-neil.com>
References: <m2acmzet7b.wl%gnn@neville-neil.com>
	 <y7vmzqulzj8.wl%jinmei@isl.rdc.toshiba.co.jp>
	 <m2k6lxu3s9.wl%gnn@neville-neil.com>
User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI)
Organization: Research & Development Center, Toshiba Corp., Kawasaki, Japan.
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
cc: freebsd-net@freebsd.org
Subject: Re: Code nit questions...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2005 21:49:05 -0000

>>>>> On Tue, 17 May 2005 11:05:10 -0700, 
>>>>> gnn@freebsd.org said:

>> > *) Insert proper return value checking.
>> 
>> in6_embedscope() should not fail in this context (so we could even
>> panic if it does), but you probably want to be very proactive by
>> eliminating as many (hidden) assumptions as possible.  If so, please
>> go ahead with the change, but then I'd rather check the return value
>> of in6_recoverscope() as well.

The latest KAME snap does not use ip6_embedscope() or
in6_recoverscope() in the corresponding part.  So, please simply go
ahead with whatever change you want to make.

BTW: you do not necessarily have to wait for the KAME snap before
committing changes to the FreeBSD repository, particularly for trivial
fixes like this one.  Of course, we always appreciate a prior notice
and solicitation of comments.

					JINMEI, Tatuya
					Communication Platform Lab.
					Corporate R&D Center, Toshiba Corp.
					jinmei@isl.rdc.toshiba.co.jp