From owner-svn-src-projects@FreeBSD.ORG Tue Apr 7 00:17:39 2015 Return-Path: Delivered-To: svn-src-projects@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF3DF47B; Tue, 7 Apr 2015 00:17:39 +0000 (UTC) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 7E104C8A; Tue, 7 Apr 2015 00:17:36 +0000 (UTC) Received: from lgwl-lstewart2.corp.netflix.com (76-247-182-56.lightspeed.sjcpca.sbcglobal.net [76.247.182.56]) by lauren.room52.net (Postfix) with ESMTPSA id 21D647E820; Tue, 7 Apr 2015 10:17:32 +1000 (EST) Message-ID: <55232218.5050401@freebsd.org> Date: Mon, 06 Apr 2015 17:17:28 -0700 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r281151 - projects/ifnet/sys/net References: <201504061522.t36FMXwX092973@svn.freebsd.org> <5522F214.5060903@freebsd.org> <20150406223108.GD64665@FreeBSD.org> In-Reply-To: <20150406223108.GD64665@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DNS_FROM_AHBL_RHSBL, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 00:17:39 -0000 On 04/06/15 15:31, Gleb Smirnoff wrote: > On Mon, Apr 06, 2015 at 01:52:36PM -0700, Lawrence Stewart wrote: > L> > Author: glebius > L> > Date: Mon Apr 6 15:22:32 2015 > L> > New Revision: 281151 > L> > URL: https://svnweb.freebsd.org/changeset/base/281151 > L> > > L> > Log: > L> > Provide software context store in struct ifnet for any facility. To add > L> > a new facility, one needs to grab a value in the ift_feature enum, and > L> > not need to modify struct ifnet. > L> > > L> > The store also has a cache to return frequently requested values, > L> > which resembles kobj(9) method cache. > L> > > L> > The plan is to move into the softc store almost all possible software > L> > contexts that hang off the struct ifnet, leaving static only the driver > L> > softc, AF_INET, AF_INET6 pointers, and other frequently used pointer. > L> > L> It seems likely that this is partially reinventing OSD(9) (also see the > L> way I used it for for khelp(9)). Perhaps OSD could be improved with some > L> useful things like the cache and then it might be a suitable drop in > L> replacement here as well? > > Yes, osd(9) looks very like. For now I'd prefer to keep the simple stuff > from r281151, to avoid introducing extra locks. Later we can estimate > osd(9). > Sounds good. Cheers, Lawrence