From owner-freebsd-hackers@freebsd.org Thu Dec 7 02:27:15 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33ED4E97B21 for ; Thu, 7 Dec 2017 02:27:15 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic312-37.consmr.mail.ne1.yahoo.com (sonic312-37.consmr.mail.ne1.yahoo.com [66.163.191.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0473A70719 for ; Thu, 7 Dec 2017 02:27:14 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1512613633; bh=y0Xpi0XofoXrEDm/BqIlm3glJYA4ocN9NtQ2+s3Uf9o=; h=To:Cc:From:Subject:Date:From:Subject; b=IvxAYrPdjq0MAXLRUGr/uzFL0+NwzxGk0hV04mpZ9ppXJMxpeMJE+oxzg9T+8AWirwlWSHOfsBgrOGbZ/yLOR8R/gO9sUyUTbUdul6M/TaTiiMmUsKQgJvU+kuiTBxS+zfVEkIml2QUUmHEy4+gs62ZFyul5eE1DsjyeKLpC9tXgeyUGQ27x1yFywCkt0N9EvDm+3YUcc14T6CWkdEfjLLd4rUWYPLKNfu/p8rYWxoao3+7V9NKZZv4cxR9JBijeLvJrSPNGuG0Ofpy5nbf+xARmbjLXtoMvtV8Dcro9jjWyYPAzUYs+9pxZ5liR5I8bjRmpmDNfuCMiRcGcmjoz/g== X-YMail-OSG: xD7ZWQAVM1nMxo04LfY2Y17T3NEscdfL5SBGP43fADAAzDVfrt6xwzwgpzJBr12 DoY65rvdXyghgwNAqVopc501ZCcilR5uIvrykxYnhZORRJgebdxqyuxsaPtiFQ806Jv4Ue.UmWjZ gZQeX34OkeoiJpj_VBJvX6IV62mAmyBD1mCM6oTbv.cfsEAmleSs2Uf4Q3m_YhCuJa_16OQo.qGz t8DiVPVnSoxnnGAdZYyOjC41QIowCXBv2DHoIs4bFTcnOxFF2yMS5ZZkaIFd90nQTnVNhS98gofH 0oCLhgXzkrTvgJQRd5uEpDDIHSn9nuj6s5xF2lVgqSHP8D1BXKsj2haO2Vbvf6YRxg4sNR9fX7il AgaiH3jkwaQ6.L0pEpf2iqFIeaTh7HX0atqgextzoN4YQhVCVyIQgnHw1XS.IyBN7XURdoUi4e4h MpeMomNAX28M87TwPYSEObyRyPDEgiKtGbwgSc4LDFQszEqteLc0Q2IQtHdhVjK8Is65lz_QL Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Thu, 7 Dec 2017 02:27:13 +0000 Received: from smtp235.mail.ne1.yahoo.com (EHLO [192.168.0.5]) ([10.218.253.206]) by smtp401.mail.ne1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID -462464354; Thu, 07 Dec 2017 02:17:06 +0000 (UTC) To: FreeBSD Hackers Cc: Steve Kargl From: Pedro Giffuni Subject: Re: SPDX tags in file? Organization: FreeBSD Project Message-ID: <4247a923-a297-1626-a576-a13651da90ab@FreeBSD.org> Date: Wed, 6 Dec 2017 21:17:06 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 02:27:15 -0000 Hi Steve; > It seems that the application of SPDX license tags > has been automated and done without reviewing whether > the tag is correct. For example, the BSD-4-Clause > tag has been placed in the files in lib/msun/bsdsrc. > Given the UCB letter concerning removal of clauses > 3 and 4, these files should probably have had the > Copyright updated and a different SPDX clause applied. > > -- > Steve The initial sweep was done manually, but as you might have noticed, it covered a lot of files and mistakes are certainly possible. The idea at this time is/was not to replace licenses: I am not a lawyer but I think we may have to look at who has touched a file before doing any license change. That may be a complex process. This said. checking for bsd-4-clause is a pretty good opportunity to review and modernize code. If the code comes from another BSD (and particularly NetBSD as I noticed during the sweep), it is likely upstream has updated the license as well and there may be interesting changes involved. Pedro.