From nobody Thu Mar 5 19:07:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fRfDr4ncZz6TWdD for ; Thu, 05 Mar 2026 19:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fRfDr3j33z44ZQ for ; Thu, 05 Mar 2026 19:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772737660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7z+1dAlMU/+hud3WY7Ks0L9852uQB7xkg6e3XkdlAA=; b=Mm7xUjyTtdYxGVL6f8CojJQa+VPQb1QoQtFZfGERZdyOuSuoPLTs+oFuJTM02WhqfGzJ4Z ZvcLf5IzXmsRtXH9/IJpLcX1jI5bgeNzT+yw289dAbfanzk3affPY27kgdMb9YJNzLQrEh g8Jdx3PsKAGN18vOma0jQmWDMdFWqvcUFwuPTBYUSF2Ft3X0X1knPJwvp+3cYm2dSk0JHz sM8/LY2T2LzinQiGITzesPJDjjlBKNEG53gg3mlf5W/Uon4bVzEk73RGPlEdVcItOSTnbx 8x4G4QN+EONo1Rgsq6Gwzah0oFl/Hw5iypw1MuMXZCzi8pCmhIvgDFmLBbf30Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772737660; a=rsa-sha256; cv=none; b=gUoYPtn+K5sVqUsdy0ERkAMvWFp0K0/kTp9deI+2dlR3osaPS34RE5unsN+MsWUZ6+AuHJ /EN1ABkBgtvlY0XAV7NeIfFo3A9Wwmbf6X+SVmzyQYBaJcMI3xBbgbco+8GYUpl7qbxlSj ahuQF1/tgwuVjGBEiNoGRMe0kDgVCD6ZLAZCxmEy8uQQ1x3XxH4BtmPIYcOXMUmwzKApo1 KzptP5Cc2nQkUkOD70DMX4IH91qtB8nUUGmtV3M9aIJzU32Ycgi15Ow46MYcWgxXVe5P0x KD7WFBjKg3JwE5pYdDfN6cUXvzGoLOwJDQ9yfNYVtXYVUBNWvFoXrapO/Y4LBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772737660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7z+1dAlMU/+hud3WY7Ks0L9852uQB7xkg6e3XkdlAA=; b=ArGBdrNFHkC1BswtwmfEzrwkRlOzNag3VJ3vFUzCjBdCrb8Zw54GMKAhnraWFCmnB84u9j TQS+koHJB945VOC8IQXzEiqSym3nFiuf2EvwScVikLDT6fO0LNI1jjWS4Zwrd2pighhuPp sTW4CAH00zl7dpQaGqjqNzD14qdiPxFkpTjS6DqPL89uO9x0zXPd/5ITVQQNuNWDtovVQQ py0n4fTVhj5FkSZ/E0ZVqvNb+JdMWgWOyfusr9/8uGUThqPGJgoNDOj4PuV62v6quwJQs1 7QJ+vUew8WjuUoP9jxcXnHaHX9j9dwH4sAlWkGsTqs3DQmhIERRzWy7t9GF5jw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fRfDr3HTQzq4l for ; Thu, 05 Mar 2026 19:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47dfc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Mar 2026 19:07:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: d19f2af2b7f9 - main - acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d19f2af2b7f9c964622fd2eba7d077c6f221b652 Auto-Submitted: auto-generated Date: Thu, 05 Mar 2026 19:07:35 +0000 Message-Id: <69a9d477.47dfc.2269a454@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d19f2af2b7f9c964622fd2eba7d077c6f221b652 commit d19f2af2b7f9c964622fd2eba7d077c6f221b652 Author: John Baldwin AuthorDate: 2026-03-05 19:07:09 +0000 Commit: John Baldwin CommitDate: 2026-03-05 19:07:09 +0000 acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR Not all bus drivers for ACPI-aware devices implement the ACPI flags IVAR used by the acpi_wake_set_sysctl handler. In some cases this may be a feature as some new-bus devices share the same ACPI handle (e.g. a pcibX device and its child pciY device) which can lead to confusing results (e.g. setting the sysctl on pciY changes the behavior of the parent pcibX device, but the "wake" sysctl for pcibX won't reflect the new behavior, or reflect the device's state). Reviewed by: obiwac, ngie, imp Differential Revision: https://reviews.freebsd.org/D55562 --- sys/dev/acpica/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c index 3a664523c27e..01b584ec30aa 100644 --- a/sys/dev/acpica/acpi.c +++ b/sys/dev/acpica/acpi.c @@ -3951,7 +3951,7 @@ acpi_wake_sysctl_walk(device_t dev) for (i = 0; i < numdevs; i++) { child = devlist[i]; acpi_wake_sysctl_walk(child); - if (!device_is_attached(child)) + if (!device_is_attached(child) || !acpi_has_flags(child)) continue; status = AcpiEvaluateObject(acpi_get_handle(child), "_PRW", NULL, NULL); if (ACPI_SUCCESS(status)) {