Date: Mon, 4 Jul 2011 13:43:12 +0200 From: Ulrich Spoerlein <uqs@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r223715 - head/contrib/gcc Message-ID: <20110704114312.GC8485@acme.spoerlein.net> In-Reply-To: <20110704112437.GT71453@hoeg.nl> References: <201107012045.p61Kju11005984@svn.freebsd.org> <20110704112437.GT71453@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, 04.07.2011 at 13:24:37 +0200, Ed Schouten wrote:
> Hi Uli,
>=20
> * Ulrich Spoerlein <uqs@FreeBSD.org>, 20110701 22:45:
> > - Port -Wtrampolines support from gcc3.
>=20
> Some testing here seems to suggest it's quite hard to write code that
> triggers this warning, while still passing WARNS >=3D 3. But still, I
> think it would be good to add this flag to bsd.sys.mk.
>=20
> I've run a `make universe' and it can be added to WARNS >=3D 2 without
> breaking the build. Maybe we should add it after we have MFCd this
> commit back to 8?
There are a couple of ports that are using our make and some of them
might even set WARNS, so I fear this would also need an exp-run to see
if there's any fallout there.
Otherwise, I think it's a good idea. Which WARNS<2 parts of our tree
would trigger that warning, btw?
Uli
% find . -name Makefile\* -exec grep WARNS {} +
=2E/benchmarks/raidtest/files/Makefile:WARNS?=3D 6
=2E/databases/sybtcl/files/Makefile.bsd:WARNS?=3D 2
=2E/graphics/gdtclft/files/Makefile.bsd:WARNS =3D 2
=2E/graphics/libfpx/files/Makefile.bsd:WARNS=3D 3
=2E/graphics/libfpx/Makefile:# (based on WARNS=3D in particular) instead of=
being influenced by
=2E/shells/v7sh/files/Makefile:WARNS?=3D 6
=2E/sysutils/ffs2recov/Makefile: WARNS=3D0
=2E/sysutils/k8temp/Makefile: @${REINPLACE_CMD} -e 's|WARNS=3D.*[6-9]|W=
ARNS=3D5|g' ${WRKSRC}/Makefile
=2E/sysutils/k8temp/Makefile:WARNS=3D 6
=2E/sysutils/lookupd/Makefile:MAKE_ENV=3D WARNS=3D0
=2E/textproc/tclExpat/files/Makefile:WARNS=3D 3
=2E/www/mod_dtcl/files/Makefile.bsd:WARNS=3D 2
PS: That does not include ports, using our make and setting WARNS in the
Makefile that they ship with ...
--sdtB3X0nJg68CQEu
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iQEcBAEBAgAGBQJOEadQAAoJEKOmmGRKr4LOTD8IAK26r/0qtGjYARnlO1fF8L5p
iFjIOngvQ/srYMjIX1AjGTLrvEkZ5ERTDVFDGaELpSjfCljDRuuGdkdM0sVg7IU7
qVTGV4PN0fdbPUhOelk/CMVdjy0D0cSJAtEzq66SnKiQL0HJiOGMbpnrvPmo9Kuy
WW97XOgYbMRVpKyVNd5yc3NBf6sjm0+MdRHPZZc0LMmstxihP4AgKmGBbe3lg4I9
S5MFBZVIZRpwPhLBnTShRkdFso6k0nveGZnbSqJv7vKYaBZC/Ro02yIez+IDS0Oh
XDJYp3fefreKCpcQc0KCs9zP+Sy8VMgJC1L4XIx0xYMFpaHcdCX12TfTaw59JC8=
=GFWY
-----END PGP SIGNATURE-----
--sdtB3X0nJg68CQEu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110704114312.GC8485>