From owner-cvs-all@FreeBSD.ORG Thu Oct 27 08:21:36 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26CA016A41F; Thu, 27 Oct 2005 08:21:36 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id C533443D75; Thu, 27 Oct 2005 08:21:26 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 32DF151A76; Thu, 27 Oct 2005 10:21:25 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id D1F3551A6E; Thu, 27 Oct 2005 10:21:19 +0200 (CEST) Date: Thu, 27 Oct 2005 10:21:16 +0200 From: Pawel Jakub Dawidek To: Yar Tikhiy Message-ID: <20051027082115.GA749@garage.freebsd.pl> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> <20051027063353.GA63896@garage.freebsd.pl> <20051027071456.GA6598@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20051027071456.GA6598@comp.chem.msu.su> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 08:21:36 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2005 at 11:14:56AM +0400, Yar Tikhiy wrote: +> On Thu, Oct 27, 2005 at 08:33:53AM +0200, Pawel Jakub Dawidek wrote: +> > On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote: +> > +> yar 2005-10-23 14:06:53 UTC +> > +>=20 +> > +> FreeBSD src repository +> > +>=20 +> > +> Modified files: +> > +> etc/rc.d ike named ppp-user sshd=20 +> > +> Log: +> > +> Don't be lazy, set the "command" variable even if +> > +> /etc/defaults/rc.conf will provide foo_program, too. +> > +> By specifying "command" we explicitly say that we're +> > +> going to rely on rc.subr(8) default methods, and +> > +> rc.subr(8) will take advantage of this soon. +> > +> =20 +> > +> The majority of our rc.d scripts already set "command" +> > +> if appropriate, so fix just the non-compliant handful. +> > [...] +> > +> name=3D"named" +> > +> rcvar=3D`set_rcvar` +> > +> +command=3D"/usr/sbin/${name}" +> > [...] +> > +> name=3D"ppp" +> > +> rcvar=3D`set_rcvar` +> > +> +command=3D"/usr/sbin/ppp" +> > [...] +> > +> name=3D"sshd" +> > +> rcvar=3D`set_rcvar` +> > +> +command=3D"/usr/sbin/${name}" +> >=20 +> > Any reason you didn't used ${name} in ppp case? +>=20 +> I was just blinded by my being solid sure that $name was "ppp-user". +> Nowever, now I'm in doubt whether $name should be "ppp". The script +> is named ppp-user and it PROVIDEs ppp-user, hence sysadmins can +> rightfully assume that its rc.conf.d file is ppp-user, too. Such +> assumption will be broken since it is $name that is passed to +> load_rc_config. I think $name should be changed to "ppp-user" in +> CURRENT. This will introduce minor incompatibility, but also +> eliminate a source of further confusion. It is confusing, but maybe we should rename ppp-user to ppp? I'm not sure how well sh(1) will handle things like ppp-user_enable=3D"YES", etc. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDYI37ForvXbEpPzQRAgedAKCqF6j3sq2XiAXmClLCQhGiBxxJ2QCfc4dB Msr9vHj2ZjP8H0pQLHSuHvA= =QKdI -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--