Date: Tue, 24 Jul 2018 16:08:50 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kirill Ponomarev <krion@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r475258 - in head/net/sniproxy: . files Message-ID: <20180724160850.GA57423@FreeBSD.org> In-Reply-To: <201807241450.w6OEoXZ6077220@repo.freebsd.org> References: <201807241450.w6OEoXZ6077220@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 24, 2018 at 02:50:33PM +0000, Kirill Ponomarev wrote: > New Revision: 475258 > URL: https://svnweb.freebsd.org/changeset/ports/475258 > > Log: > Utilize SOCK_NONBLOCK instead of O_NONBLOCK > > Added: head/net/sniproxy/files/patch-src_connection.c > ... > +- O_NONBLOCK); > ++ SOCK_NONBLOCK); It would be nice if commit message also included the rationale for this change (per our 30%-what-70%-why rule). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180724160850.GA57423>