From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 7 18:43:28 2008 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 736A9106566B for ; Fri, 7 Mar 2008 18:43:28 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157]) by mx1.freebsd.org (Postfix) with ESMTP id E8A4B8FC2D for ; Fri, 7 Mar 2008 18:43:27 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so510676fgg.35 for ; Fri, 07 Mar 2008 10:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=3dGuM4BNlnNgP086uAKIrlkDA/U0YkeJ9FAjiTlXkQs=; b=h1HrPpnul0PoGqW77ZYZEZIQmNwZG1VIuetN+KR5d1VEDJIU9b9Ut6OBgtuZW0e4VLU6OKlNF0lBK9Zc2GLmHF5ntUqMRlpXQz4y/3nDvCFlPXfBP51cbZ9R7UtSrCdPMU1FeO8oysgH8xCB2Ew57BLOdzqoqPo8RiH39UPHrDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jhZw6sNCGJIOBkKx9nJfU3nhWJNBO3CAJOb7HsM0+svXOSYdq/7XVTwGl7thAiHxxLjd1s2BPvJ7WWgiU6GOYvbZobZ1Gk6VE+11JcPYWbvPj9eHkugCIkUA8gQbgIH2TCBZ+C7H8+2vProRbvCeaRrLpN3rL0+dCU7XKq17uvQ= Received: by 10.86.28.5 with SMTP id b5mr1847328fgb.47.1204915406499; Fri, 07 Mar 2008 10:43:26 -0800 (PST) Received: by 10.86.23.12 with HTTP; Fri, 7 Mar 2008 10:43:26 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2008 10:43:26 -0800 From: "Maksim Yevmenkin" To: "Brooks Davis" In-Reply-To: <20080307180907.GA45978@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <20080307180907.GA45978@lor.one-eyed-alien.net> Cc: usselmann.m@icg-online.de, freebsd-bugs@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 18:43:28 -0000 On Fri, Mar 7, 2008 at 10:09 AM, Brooks Davis wrote: > On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wrote: > > > The following patch should allow profile name to contain ".-/+" characters > > > as we do with interfaces. It also documents the previous undocumnted > > > per-profile overrides of _mode and _nat which were the cause of the problem. > > > If someone who uses ppp could test this, I'd be happy to commit it. > > > > i'm not so sure about this one. if i have "t-dsl" as a profile name, i > > will not be able to specify any overrides for this profile, because > > shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" > > variable. so, the translation here is not really needed, imo, and, > > perhaps, could even be considered harmful. perhaps we should do one of > > the following > > The point of the patch is to change all ".-/+" characters to _ which > means the variable will be ppp_t_dsl_(mode|nat) so you can use the > profile overrides. It's an exact copy of the code we use for interface > variables. i get that. what i was trying to say is that overrides for the "t-dsl" profile (with hyphen) are now, obviously, "ppp_t_dsl_mode" and/or "ppp_t_dsl_nat". to me, it is somewhat confusing. another (pretty weak :) argument is that all ".-/+" characters are mapped onto single "_" character. this could potentially create a collision in variable names. i realize that you have done exactly the same thing as in get_if_var() in network.subr. are there any examples of network interface variable names that are not "shell clean"? > > 1) demand that ppp profile names should be "shell clean" and document it > > > > or > > > > 2) if a ppp profile name is not "shell clean" simply do not evaluate > > profile overrides and use defaults > > I'm opposed to 2. I'd be OK with 1, but think folding common > punctuation into _ may be a better option given that we're already doing > it elsewhere. i'm still not sure :) however, please do not take it as an objection :) since we already have similar code (and no one, including me, complained :), it probably makes more sense to do the same here. thanks, max