Date: Sat, 27 Oct 2001 20:27:26 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Andrew Gallatin <gallatin@cs.duke.edu>, Bruce Evans <bde@FreeBSD.org> Cc: alpha@FreeBSD.org, Matthew Jacob <mjacob@FreeBSD.org> Subject: Makefile.inc1 clobbers CFLAGS (was: Re: cvs commit: src Makefile.inc1) Message-ID: <20011027202726.A61277@sunbay.com> In-Reply-To: <15320.9098.473721.706566@grasshopper.cs.duke.edu>; from gallatin@cs.duke.edu on Thu, Oct 25, 2001 at 10:36:58AM -0400 References: <200110250728.f9P7Suo32144@freefall.freebsd.org> <20011025103739.B62879@sunbay.com> <15320.6175.46379.397080@grasshopper.cs.duke.edu> <20011025171401.A22980@sunbay.com> <15320.8258.898824.156679@grasshopper.cs.duke.edu> <15320.9098.473721.706566@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Thu, Oct 25, 2001 at 10:36:58AM -0400, Andrew Gallatin wrote:
>
> Andrew Gallatin writes:
> >
> > Building now. One more question I have CPUTYPE=ev56
> > in /etc/make.conf -- will the crossbuild see this, potentially
> > confusing the x86 gcc?
>
> Yes, it will.. :
>
> cc1: bad value (ev56) for -mcpu= switch
>
> Removing ev56 & restarting...
>
This is because Makefile.inc1 sets CFLAGS="-nostdinc ${CFLAGS}" in
CROSSENV, and that imports currently effective (for host architecture)
CFLAGS. This is bogus. The attached patch should fix it. Please
test.
Bruce, what do you think about bringing COPTFLAGS in userland,
and adding CINCLUDES?
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=p
Index: Makefile.inc1
===================================================================
RCS file: /home/ncvs/src/Makefile.inc1,v
retrieving revision 1.220
diff -u -p -r1.220 Makefile.inc1
--- Makefile.inc1 2001/10/25 07:28:55 1.220
+++ Makefile.inc1 2001/10/27 17:22:48
@@ -171,8 +171,8 @@ CROSSENV= MAKEOBJDIRPREFIX=${OBJTREE} \
COMPILER_PATH=${WORLDTMP}/usr/libexec:${WORLDTMP}/usr/bin \
LIBRARY_PATH=${WORLDTMP}${SHLIBDIR}:${WORLDTMP}/usr/lib \
OBJFORMAT_PATH=${WORLDTMP}/usr/libexec \
- CFLAGS="-nostdinc ${CFLAGS}" \
- CXXINCLUDES="-nostdinc++ ${CXXINCLUDES}" \
+ CINCLUDES="-nostdinc" \
+ CXXINCLUDES="-nostdinc++" \
PERL5LIB=${WORLDTMP}/usr/libdata/perl/5.6.0 \
GROFF_BIN_PATH=${WORLDTMP}/usr/bin \
GROFF_FONT_PATH=${WORLDTMP}/usr/share/groff_font \
Index: share/mk/sys.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/sys.mk,v
retrieving revision 1.56
diff -u -p -r1.56 sys.mk
--- share/mk/sys.mk 2001/08/31 12:20:43 1.56
+++ share/mk/sys.mk 2001/10/27 17:22:48
@@ -39,7 +39,9 @@ CC ?= c89
.else
CC ?= cc
.endif
-CFLAGS ?= -O -pipe
+
+COPTFLAGS ?= -O -pipe
+CFLAGS ?= ${COPTFLAGS} ${CINCLUDES}
CXX ?= c++
CXXFLAGS ?= ${CXXINCLUDES} ${CFLAGS}
--tKW2IUtsqtDRztdT--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011027202726.A61277>