From owner-freebsd-net@FreeBSD.ORG Wed Aug 19 18:14:34 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47963106568E for ; Wed, 19 Aug 2009 18:14:34 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from n3a.bullet.mail.ac4.yahoo.com (n3a.bullet.mail.ac4.yahoo.com [76.13.13.66]) by mx1.freebsd.org (Postfix) with SMTP id E97958FC65 for ; Wed, 19 Aug 2009 18:14:33 +0000 (UTC) Received: from [76.13.13.25] by n3.bullet.mail.ac4.yahoo.com with NNFMP; 19 Aug 2009 18:14:33 -0000 Received: from [76.13.10.183] by t4.bullet.mail.ac4.yahoo.com with NNFMP; 19 Aug 2009 18:14:33 -0000 Received: from [127.0.0.1] by omp124.mail.ac4.yahoo.com with NNFMP; 19 Aug 2009 18:14:33 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 316750.39893.bm@omp124.mail.ac4.yahoo.com Received: (qmail 42257 invoked by uid 60001); 19 Aug 2009 18:14:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1250705673; bh=9vM9JXyk+Q653jWtUZybvIYxS5FjTgxxFpoYCniJDNc=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=QZgl4jcOrcsX+1E1UwWIrDsbxnDrV5O6cy2eT6p65Jm04oFiQl+AhAN01k26hmrLA9q5xZeIf31VvopO8/4sGVVZFh+uPVIomL0BIMXmHApHrKhX9PNjTD/wzq6jha/n9uu43QPOPxokcqZmK4SgedkeTmsvdZVn73U+9m+ysos= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=hNPVrC0uxgCYm7dZOi6CGJRheU7fMXD3Jtb8HnSxWh061nVpNA9+govTmBVEyMJjgQBN9l+ZMs/W+ZmWLnZDAaMG7ysu3Slvzjs5teDnRhgRfq30+w2++KS/VNlD3NU48nctDNvVu5tObVi01x9rt3FLPrhKHprMo00MsoKutGo=; Message-ID: <121870.41829.qm@web63905.mail.re1.yahoo.com> X-YMail-OSG: OoysDLUVM1nXmW5mFnFnUc08IWIr0a4DFAk4i_xjquCEIk78IYZhb5tQCf3jhGYn7xTPZfl.rq4EoNqCXji6x9cKzge6CwcEold2gnFsnpW9FXRomBneymjG723VT_fVd0AZWn8qK_xYsebrMvIPTznS.XcoVVNnk5h1zTlG2T9MC6U5yvZMs666unrEE07.enobi9fsYzihRhWoGs89.wdXuWfI2QMKo5TXr2tjer71lg6kdCnUBzYsPkSEQr3V4QfgbbAcssKLepzrr8NGFuvPzRiGYHNEn40ZN5GzcXjAgnLXPMMAXR43uSEELJI87duuSXcv.lcfJQ5fj19bezH7.A-- Received: from [66.176.162.245] by web63905.mail.re1.yahoo.com via HTTP; Wed, 19 Aug 2009 11:14:32 PDT X-Mailer: YahooMailClassic/6.1.2 YahooMailWebService/0.7.338.1 Date: Wed, 19 Aug 2009 11:14:32 -0700 (PDT) From: Barney Cordoba To: d@delphij.net, Julian Elischer In-Reply-To: <4A8B316F.3030408@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: pyunyh@gmail.com, David Christensen , "freebsd-net@freebsd.org" , Jack Vogel , Jack F Vogel , yongari@freebsd.org Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2009 18:14:34 -0000 =0A=0A--- On Tue, 8/18/09, Julian Elischer wrote:=0A= =0A> From: Julian Elischer =0A> Subject: Re: [PATCH] F= ix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of= NOARP flag]=0A> To: d@delphij.net=0A> Cc: pyunyh@gmail.com, "Barney Cordob= a" , "David Christensen" , = "freebsd-net@freebsd.org" , "Jack Vogel" , "Jack F Vogel" , yongari@freebsd.org=0A> Date:= Tuesday, August 18, 2009, 6:55 PM=0A> Xin LI wrote:=0A> > -----BEGIN PGP S= IGNED MESSAGE-----=0A> > Hash: SHA1=0A> > =0A> > Barney Cordoba wrote:=0A> = >> --- On Tue, 8/18/09, Pyun YongHyeon =0A> wrote:=0A> >>= =0A> >>> From: Pyun YongHyeon =0A> >>> Subject: Re: [PATC= H] Fix for e1000 (em/igb)=0A> NOARP issue [Was Re: em(4): sending ARP regar= dless of NOARP=0A> flag]=0A> >>> To: "Xin LI" =0A> >>>= Cc: "Barney Cordoba" ,=0A> "David Christensen" <= davidch@broadcom.com>,=0A> "d@delphij..net"=0A> ,=0A> "freeb= sd-net@freebsd.org"=0A> ,=0A> "Jack Vogel" ,=0A> "Jack F Vogel" ,=0A> yongari@freebsd.org= ,=0A> "Julian Elischer" =0A> >>> Date: Tuesday, August= 18, 2009, 5:49 PM=0A> >>> On Tue, Aug 18, 2009 at 02:03:37PM=0A> >>> -0700= , Xin LI wrote:=0A> >>>> -----BEGIN PGP SIGNED MESSAGE-----=0A> >>>> Hash: = SHA1=0A> >>>>=0A> >>>> Hi, Jack,=0A> >>>>=0A> >>>> I have looked into the c= ode history and=0A> found that=0A> >>> sys/dev/em/if_em.c,v=0A> >>>> 1.119 = has introduced the arp_ifinit() call=0A> in order to=0A> >>> fix the proble= m=0A> >>>> that if_em won't send ARP when IP address=0A> is changed.=0A> >>= >>=0A> >>>> I think we can further improve it as=0A> attached, say,=0A> >>>= only do it when=0A> >>>> IFF_NOARP is not set.=A0 This should=0A> have no = effect=0A> >>> for usual=0A> >>>> configuration but fix the problem when=0A= > NOARP is the=0A> >>> desired behavior.=0A> >>> That change was introduced= by me. I guess the=0A> root cause of=0A> >>> the=0A> >>> problem was long = initialization time of=0A> hardware which in=0A> >>> turn=0A> >>> resulted = in unbearable boot time when=0A> multiple-alias=0A> >>> addresses are=0A> >= >> assigned to em(4). I don't remember=0A> details,though.=0A> >>>=0A> >>> = Since we're in the release cycle, the change=0A> you suggested=0A> >>> woul= d be=0A> >>> quick fix for 8.0. I think em(4)/igb(4) should=0A> remove=0A> = >>> SIOCSIFADDR=0A> >>> handling in driver which is layering=0A> violation.= =0A> >> There are 2 kinds of programmers; those who do=0A> things "correctl= y',=0A> >> and those that do things that work. =0A> >>=0A> >> 99.99999% of = the people will be using ARPs, so=0A> don't be silly and=0A> >> break the d= river to solve a case that almost=0A> no-one cares about please.=0A> > =0A>= =0A> Cisco.Ironport=A0 runs 50% (2 out of 4) of their em=0A> interfaces in= noarp =0A> mode.=0A=0A=0AAh, are they running Jack's drivers unmodified? S= eems unlikely.=0A=0ANOARP does work. Does your network catch on fire if the= interface sends=0Aan ARP out? Does equipment start failing like dominos? = =0A=0AMy point was don't make ARPs not work (the reason the "hack" is in=0A= there is to make something work better) to preserve some fantasy of=0A"laye= ring" that went out with the 8-track player. The check for =0Athe NOARP fla= g is a better solution until the subsystem works the =0Away its supposed to= work.=0A=0ABarney=0A=0A=0A