From owner-svn-src-head@FreeBSD.ORG Sat Feb 7 05:31:57 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ABDEF9AA; Sat, 7 Feb 2015 05:31:57 +0000 (UTC) Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C0AE91B; Sat, 7 Feb 2015 05:31:57 +0000 (UTC) Received: by pdev10 with SMTP id v10so1677607pde.7; Fri, 06 Feb 2015 21:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=hc9SDEw477hFRT7nWunW0GekMkT10QOKVIzIsKMTpno=; b=O6kv1pTPABELvU7sDJLc4fjdDxo/D36qAoXnnZ9eK2E0K72n7/DabZ6gaWLZEqAWfL +45ZS/wXIdm9mqIm0NIvJPD+nEOwA254CJhPRA9r9lxp8eDL1RGJ3f6C2THqpOC8Lg+h fZMAua4KX9blWFb64koo05ho22apvYa8u/77QZncCLo4gcuOu053C5mngUDsCuD/d3/v J9OBZfYmcV+Oz3OVu6uWQIwuLduK00yPzcvjH2g9fnD9oYPvQ1SbZZ+CtwDdGMdaNxxg rXicnKbHIu2Q4jlr/m1lx//PVXRki/kPWCvmO3UXoUugdPJrlIiBXIlOn/lh5I5Klo08 cO1Q== X-Received: by 10.70.128.202 with SMTP id nq10mr11082463pdb.45.1423287116522; Fri, 06 Feb 2015 21:31:56 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:e47d:5c02:fe5f:40fa? ([2601:8:ab80:7d6:e47d:5c02:fe5f:40fa]) by mx.google.com with ESMTPSA id ys5sm9725564pbc.17.2015.02.06.21.31.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Feb 2015 21:31:56 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_99023C41-B0DF-443E-A458-5076B171C6F7"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r278323 - in head: etc/rc.d usr.sbin/jail From: Garrett Cooper In-Reply-To: <609da07b7a80b4a59fce8655370b045e@gritton.org> Date: Fri, 6 Feb 2015 21:31:55 -0800 Message-Id: References: <201502061754.t16HssXU042750@svn.freebsd.org> <609da07b7a80b4a59fce8655370b045e@gritton.org> To: James Gritton X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2015 05:31:57 -0000 --Apple-Mail=_99023C41-B0DF-443E-A458-5076B171C6F7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 6, 2015, at 21:27, James Gritton wrote: > On 2015-02-06 22:18, Garrett Cooper wrote: >> On Feb 6, 2015, at 9:54, Jamie Gritton wrote: >>> Modified: head/usr.sbin/jail/command.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/usr.sbin/jail/command.c Fri Feb 6 17:43:13 2015 = (r278322) >>> +++ head/usr.sbin/jail/command.c Fri Feb 6 17:54:53 2015 = (r278323) >>> @@ -112,6 +112,12 @@ next_command(struct cfjail *j) >>> if = (!bool_param(j->intparams[IP_MOUNT_FDESCFS])) >>> continue; >>> j->comstring =3D &dummystring; >>> + break; >>> + case IP_MOUNT_PROCFS: >>> + if = (!bool_param(j->intparams[IP_MOUNT_PROCFS])) >>> + continue; >>> + j->comstring =3D &dummystring; >>> + break; >> Did you intend on adding another break? The code would previously = fall >> through to the next case statement... >>> case IP__OP: >>> case IP_STOP_TIMEOUT: >>> j->comstring =3D &dummystring; >=20 > Yes. The code did indeed previously fall to the next case, but it was = a no-op: the next case only had the same exact assignment that had just = taken place (j->comstring =3D &dummystring). The lack of a break that = had existed before was just some sloppy coding that I didn't notice at = the time because it didn't actually change any behavior. Nonetheless it = seemed worth correcting when I noticed it. True. I looked at the code afterwards and it looks ok. mount.procfs = doesn=92t exist in my environment. Is that command correct? $ which mount.procfs; echo $? 1 --Apple-Mail=_99023C41-B0DF-443E-A458-5076B171C6F7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU1aNLAAoJEMZr5QU6S73eJWoH/1d0mHer/sj8l48uf+qzX5EX OiKi+i6ScqMMcwUb43wPFkfv8ItCB9nmVW46y1++wOq+dbgUz91zU1/WyWER+YQv Z6NOjwMv3XwkV3l5VXR9h9e2pFYWx/ang7pR/o8pe8LFWCOLipEkZ0qyi2vg82bQ DyxYvzrlkqva7kH+2BY1+mji18oo7lb1IToYUj7Q+yZPwAwk6N8BdpIz/keCkU1d tJWCQU9r04wq+4nt1rjGRkWBi4z2wZrFiASuQIDZ/P22ZKsywq2HpZT1QvlhY/GQ HeoGs84r8lK0JgVNnfjNRFbHE+UffrPdSC2QbOKLltMooxfjTPFa9J1NQa6wrc4= =V7M3 -----END PGP SIGNATURE----- --Apple-Mail=_99023C41-B0DF-443E-A458-5076B171C6F7--