From owner-svn-src-head@FreeBSD.ORG Sat Apr 11 17:44:07 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9ADA106564A for ; Sat, 11 Apr 2009 17:44:07 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 79AA08FC0A for ; Sat, 11 Apr 2009 17:44:07 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id 7A42D8FC52 for ; Sat, 11 Apr 2009 21:44:06 +0400 (MSD) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id E15BE8FC1D; Sat, 11 Apr 2009 21:44:02 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 7A0E73981A; Sat, 11 Apr 2009 21:44:10 +0400 (MSD) Date: Sat, 11 Apr 2009 21:44:10 +0400 From: Stanislav Sedov To: Norikatsu Shigemura Message-Id: <20090411214410.c53d0fb1.stas@FreeBSD.org> In-Reply-To: <20090412021841.673a200b.nork@FreeBSD.org> References: <200904111657.n3BGvpsC092703@svn.freebsd.org> <20090411210702.ce5325b9.stas@FreeBSD.org> <20090412021841.673a200b.nork@FreeBSD.org> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Sat Apr 11 21:44:06 2009 X-DSPAM-Confidence: 1.0000 X-DSPAM-Improbability: 1 in 98689409 chance of being spam X-DSPAM-Probability: 0.0023 X-DSPAM-Signature: 49e0d6e6967003214620014 Cc: svn-src-head@FreeBSD.org, vd@FreeBSD.org, David Schultz , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r190943 - head/include X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 17:44:08 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, 12 Apr 2009 02:18:41 +0900 Norikatsu Shigemura mentioned: > On Sat, 11 Apr 2009 21:07:02 +0400 > Stanislav Sedov wrote: > > > Log: > > > GNU Pth has some fragile kludges that were broken by r189828. > > > I've discussed this with the Pth maintainer and no clear solution > > > has emerged on the ports side of things, so for now, hack around > > > the issue in signal.h. > > Can't we just put a patch in ports tree itself? What meant under 'no > > clean solution emerged'? I can prepare a patch, if needed. > > I think so, too. I have a quick hack patch. > > ports/devel/pth/files/patch-pth_p.h.in > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > --- pth_p.h.in.orig 2006-06-09 02:54:03.000000000 +0900 > +++ pth_p.h.in 2009-04-08 15:05:12.911807009 +0900 > @@ -32,7 +32,7 @@ > #include > #include > #include > -#include > +//#include > #include > #include > #include > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > Or just drop the line. Vasil, what do you think about the possibility to commit this patch into the tree? I think we should have a workaround in ports tree (it is one of the things what it was designed for) than in the src tree. Better would be to implement a workaround upstream, though. I think something like #if !(defined(__FreeBSD__) && __FreeBSD_version >= %%PTHREAD_CHANGE_VERSION%%) #include #endif where %%PTHREAD_CHANGE_VERSION%% would correspond to the __FreeBSD_version where the change was introduced, could be safely submitted upstream. - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkng1uoACgkQK/VZk+smlYErSwCfbHR20spUIzAvATR9wvWvco5B RBkAn0Ailghm/yDk2kjImZLVnGXqiGAc =KTfP -----END PGP SIGNATURE----- !DSPAM:49e0d6e6967003214620014!