From owner-freebsd-net@freebsd.org Tue Aug 18 18:56:50 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C36BE3C4234 for ; Tue, 18 Aug 2020 18:56:50 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWKrx4WCKz4VHT for ; Tue, 18 Aug 2020 18:56:49 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ml6HJXGhliuNtI2tdeIKSA2RL0I9SaYxMOEmqxGDLEZM0HOt1BNOpVNn4dQjsXKGHD43zwpNgCAyA7ZQdaRjhjGoP3pbseApmVdDxQP/J3ZRUmhN26/+5/PMLu8wDNPdZzkN3C4P3kE5lU7SlKJx8JtEvgpoNAE9HSqUhywfFojBd3kWsxYOAdAK7uxA3Mqv+i9t8iKwrWF68y+9kbblKVJyH6ZPAU+3t82tf4sXNA755zpy1bcGFEjV6OLT5ekXrTh9GVEHigdCLjKvENFk1RgIwHF7DBVj+FhjP/f1v+65vYkLNQJzKyqfTl5UNBBdBsdc6lgDzgb/mW//b4JLvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4f4kes2ibck5oVuKhU2CHADCJ0HZYpDc0L37knNqX4A=; b=HrxrETtb38OpMVMbU+Hf3TcXrj0RsStnNa3F+7k0sibmyl5tAUezVvT5Bm4z/+NIiK+5DVSrhT+f69SiJOpujhKSMdJzmhqVGxj6UdCFB9R+0phkytOCuv/mGmh1EaRZGBoZaGL2xVfLvjE10bVS2JS58hPE5UiR2cIshMo1Khy+U4aNludk1WqzOr6y8E7lVJq2HIhAzHwN7tLZDV1k1xcybYVs3PrJ8rntKUUbbJ/m0QeYUtDUjisJe5ZAPXOB7QWY+UL3lSGTo+IKuldal0Gg3LSp9DDcmG/tvqzmndrIFHvcDPWqueTIkHcsG0kgxiivjmIxKidsDuAoKEePjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4f4kes2ibck5oVuKhU2CHADCJ0HZYpDc0L37knNqX4A=; b=BvBv4fNbT7ywpsnAY9NrMkE8gNhBVlAeXHJy5Iq9MGwPoPEzZBA2cSug9PhhPW+KeQ7crD3szauzTvkH6ubQj8w/xY/Lac/z3c2/e95kxEi78JavU/eUlEz6LYS+e1ZdEarXIXSmjq+TTUu8Tn4s7CcKf5gIcm16Z4MpMIWamss= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VE1PR08MB4685.eurprd08.prod.outlook.com (2603:10a6:802:ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22; Tue, 18 Aug 2020 18:56:46 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f8f2:29a2:4263:4647%6]) with mapi id 15.20.3283.026; Tue, 18 Aug 2020 18:56:46 +0000 Date: Tue, 18 Aug 2020 20:57:25 +0200 From: Marko Zec To: Ryan Stone Cc: freebsd-net Subject: Re: Is anybody using ng_pipe? Message-ID: <20200818205725.2e03c8cb@x23> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0602CA0004.eurprd06.prod.outlook.com (2603:10a6:800:bc::14) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (31.147.2.0) by VI1PR0602CA0004.eurprd06.prod.outlook.com (2603:10a6:800:bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Tue, 18 Aug 2020 18:56:44 +0000 X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [31.147.2.0] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e93fcb33-41ad-45a5-0a6f-08d843a87485 X-MS-TrafficTypeDiagnostic: VE1PR08MB4685: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u1GHOM3scaGwa8+Dc3O618GrqnuWCFENUytJ4HaSlE1YU3Fm2+MKlLEt+pAB6vKnnvdyqopchIgdVkc4AbcwVaHn4EdRjP0ib2i7is4fPPbJ3Z92PIIG2w50zyJsyzxxXW+NU8Lfn14q8cyv6aqwgJtrB7OBjMu7ekeu54HPaTPCQ/zm1xpb2fp9uBqL6/L1X2HpMItA4ZrE0b9dhjg+8vPUSWqBkIY+DUkk79Z0LhCHeZT5w9g3qPS5azyDFGEHmOo0dsLCWbc5hIZZ4+TgBdyO2yh94+cM6QM4JvghVWBQOXo3Xq1QkFOfm42yV1iI1YIWnG2EY5suUIO+1uwvuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(39840400004)(346002)(376002)(396003)(366004)(136003)(186003)(86362001)(16526019)(53546011)(5660300002)(956004)(6666004)(6916009)(4326008)(8676002)(9576002)(316002)(2906002)(66476007)(786003)(55016002)(6496006)(33716001)(8936002)(66946007)(478600001)(26005)(52116002)(1076003)(9686003)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: NfFK8kCBoHrjjsrDKr6pbHEcuLvkuyrVshNdQfEYuXivE57zPMjLsOJAqiz8GucfyGa95K7VXjYYx5WvpJ9anjey2hJ1ODNHbrRKnj9OGCE/K4FmXjWwntWHtsskM5HGcQADZk7p9PePAPkmLiAuWKfHaWFVLHTHJW3v0vP+bXI/ZgElvdm3WNQJkYG6fP4e2s+VHN8amT8zVTHzuMvv68AwJe328wk5DfEkaR/6fUh/0iXjAJXXXWLXQH63GXwm3mK4OohvRdmVBMFbqsP2ikMMqLVintmrfW95pJD5C7Y7ZcEBblBkLJa026qPuEPo4LvsuBnQ7v90RLZRIp2vTG+/EdQNkpBl/70ZcAN8j6EIacKWu1Ns3T4JVJ1XI+hdkbrkwYzTxEItvd/q5m+ZI3CLXqDnTFwMxkiAMzqqPxmqZqvB21N15q11t3ZSCiC9LMJwmGQ6sIN3fVD2YQEN29RqkQ+FPgP4S+HlDzh2aZrVi3UC9QLmWhyiEDq0zSC8E0mgPn3lAximAu2vOlkCAFRpTAsAQdiL7CNAC8VyvWwLDvkM+sU2AmuGaiKD12biiqRWXqrTcl7lEoRkxzhQXCCD/fTYYHBMgfz0xV6rVDG6jHwe8+w7pob2Xsba7ChP X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: e93fcb33-41ad-45a5-0a6f-08d843a87485 X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 18:56:46.3616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rogZbC5pL4bUE/C8Dfk7iKx3WmEKScBlOqnFu4VkKemIUUAPgHf1MqP3wpE+TB0W X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4685 X-Rspamd-Queue-Id: 4BWKrx4WCKz4VHT X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=BvBv4fNb; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 40.107.22.79 as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-1.02 / 15.00]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[zec]; RECEIVED_SPAMHAUS_PBL(0.00)[31.147.2.0:received]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.92)[-0.916]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.22.79:from]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_IN_DNSWL_LOW(-0.10)[40.107.22.79:from] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 18:56:50 -0000 On Tue, 18 Aug 2020 13:17:48 -0400 Ryan Stone wrote: > I'd like to dump all of this and just implement a packet loss rate, > which would simplify all this immensely. Is anybody using ng_pipe > with a non-zero BER who would object to this? Given this litany of > issues I doubt it, but I thought that I'd be sure. Yes, the BER feature is being actively used, please don't nuke it. If you wish to supplement it with PER, which is less realistic but simpler to implement, by all means go ahead... > On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone wrote: > > 4. The table calculation had two integer truncation bugs and used > > the wrong formula. I'm reasonably sure it would never calculate a > > probability other than 0 due a 64-bit constant being truncated to > > 32-bits. > > I've gone back and checked, and I was partially wrong on this point. > I had gotten the idea that integer literals would be truncated to int, > which is not true. The use of the wrong formula still means that > packets are dropped at entirely the wrong rate, though. The probability that a frame is completely unaffected by BER events, and thus shouldn't be dropped, is currently computed as Ppass(BER, plen) = Psingle_bit_unaffected(BER) ^ Nbits(plen) where Nbits(plen) = plen * 8 + user-configurable framing overhead. This is a crude model yet one which was fairly simple to implement. Could you elaborate why you consider it to be entirely wrong? Cheers, Marko