From owner-svn-src-all@freebsd.org Thu Jan 23 19:09:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BA571FAD63; Thu, 23 Jan 2020 19:09:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 483Wz05Sf6z40hq; Thu, 23 Jan 2020 19:09:00 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x734.google.com with SMTP id v195so4518127qkb.11; Thu, 23 Jan 2020 11:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xiHfADZjhYz7UeEHFWuCaD/lXK/DK4+9KnVP95p8AwE=; b=cDRRpoHrJDBVnTtXCKJ4SLVYUYveeXBQCwIx61QIK9+hjw7N3rtejC4RWzGn4/TWMF YMo0JlJjqcDAc9SFVKtB6xJ7i/rvw3dVJUtpi2YFKXU1PNCYk6aHns5BA80YZaCuaZs4 yrlqYZKag35zVG9mPaM1wDk4cnTB4wjIncmJtsgNOuIbQQGEWhs7d6uBtwBGJlnDFkT2 Gr3DllfyVSQKZ8YNbDqfZLkdsOrqJZnCRQo192Yb1VKgEIJZeBVieaQ/PGnfZMU/wjpX NXzUwMtg0eAJeqWDElVeqatc3d0238KhL8akxZARXRVuJVbKUBzai7QPtWD6QOYOSEW+ t4qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=xiHfADZjhYz7UeEHFWuCaD/lXK/DK4+9KnVP95p8AwE=; b=EATPDYIWAnoebYNLeWzRwxZQPICnJkKEcqdyQamZtfmfMI1Tb8mEWOcTTUjhDyRhxA ArNBy2jw3j5GIlTT+jYttO+DlVXrAKAyqv+Rjs2KKEHfeAmbLeucsmtaIq/KVlbi5Pe/ SlclAsQVKvBvwo1rZYCWfKRCXQZLwLsdTpDmf8nRTNklbTUfhd7VaccQnkHcEOCNmEBZ E9E3Ue0kFHTInNCo817PfRA//q7nMH3XjUdccwlqglAXXPrRW0bsZGzX/TsZKNEsAkwd l+fuarnXO/Haul/ujM3rb4lQf5+v7UCn0wuX6cF5/fk4IwKyGvV2VCPxIu85ar3OdgDj UpEA== X-Gm-Message-State: APjAAAUrFiHxa9M1YCGeyBIhIS9NPTH2kPogMdXtNcusaZ71YkICgS6s dVUEtrW29xrlGXuaeXDLqAcq4E6B X-Google-Smtp-Source: APXvYqynZvOqV+Z8AbmWm573glzrUOn0VvE3WRr2gwLtiDGTt2xrkRK1aJXf9jqXrHaNuJ3PLw8Mxg== X-Received: by 2002:a05:620a:15b3:: with SMTP id f19mr16914686qkk.362.1579806538143; Thu, 23 Jan 2020 11:08:58 -0800 (PST) Received: from spy (ip-45-3-14-96.user.start.ca. [45.3.14.96]) by smtp.gmail.com with ESMTPSA id 124sm1397641qko.11.2020.01.23.11.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 11:08:57 -0800 (PST) Sender: Mark Johnston Date: Thu, 23 Jan 2020 14:08:55 -0500 From: Mark Johnston To: Jeff Roberson Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357055 - head/sys/sparc64/sparc64 Message-ID: <20200123190855.GC87818@spy> References: <202001231718.00NHIwq7004333@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 483Wz05Sf6z40hq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cDRRpoHr; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::734 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-4.33 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.63)[ip: (-9.23), ipnet: 2607:f8b0::/32(-2.07), asn: 15169(-1.81), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2020 19:09:01 -0000 On Thu, Jan 23, 2020 at 08:22:55AM -1000, Jeff Roberson wrote: > On Thu, 23 Jan 2020, Mark Johnston wrote: > > > Author: markj > > Date: Thu Jan 23 17:18:58 2020 > > New Revision: 357055 > > URL: https://svnweb.freebsd.org/changeset/base/357055 > > > > Log: > > sparc64: Busy the TSB page before freeing it in pmap_release(). > > > > This is now required by vm_page_free(). > > > > PR: 243534 > > Reported and tested by: Michael Reim > > > > Modified: > > head/sys/sparc64/sparc64/pmap.c > > > > Modified: head/sys/sparc64/sparc64/pmap.c > > ============================================================================== > > --- head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:08:33 2020 (r357054) > > +++ head/sys/sparc64/sparc64/pmap.c Thu Jan 23 17:18:58 2020 (r357055) > > @@ -1302,6 +1302,7 @@ pmap_release(pmap_t pm) > > m = TAILQ_FIRST(&obj->memq); > > m->md.pmap = NULL; > > vm_page_unwire_noq(m); > > + vm_page_xbusy(m); > > vm_page_xbusy() is unsafe long-term and I will be removing it as soon as I > get patches into drm. It technically 'works' now but not for great reasons. Yeah, this is just to satisfy the interface contract. These pages are unmanaged, so it really shouldn't make a difference. > Thanks, > Jeff > > > vm_page_free_zero(m); > > } > > VM_OBJECT_WUNLOCK(obj); > >