From owner-cvs-all@FreeBSD.ORG  Thu Jul 14 12:36:15 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F98516A41C;
	Thu, 14 Jul 2005 12:36:15 +0000 (GMT)
	(envelope-from gallatin@cs.duke.edu)
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CEAD243D49;
	Thu, 14 Jul 2005 12:36:14 +0000 (GMT)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30])
	by duke.cs.duke.edu (8.13.4/8.13.4) with ESMTP id j6ECaDRT007455
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 14 Jul 2005 08:36:13 -0400 (EDT)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id j6ECa8aX021263; 
	Thu, 14 Jul 2005 08:36:08 -0400 (EDT) (envelope-from gallatin)
Date: Thu, 14 Jul 2005 08:36:08 -0400
From: Andrew Gallatin <gallatin@cs.duke.edu>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20050714083608.A21239@grasshopper.cs.duke.edu>
References: <200507131406.j6DE6DLv066313@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200507131406.j6DE6DLv066313@repoman.freebsd.org>;
	from glebius@FreeBSD.org on Wed, Jul 13, 2005 at 02:06:13PM +0000
X-Operating-System: FreeBSD 4.9-RELEASE-p1 on an i386
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_xl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 12:36:15 -0000

Gleb Smirnoff [glebius@FreeBSD.org] wrote:
> glebius     2005-07-13 14:06:13 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/pci              if_xl.c 
>   Log:
>   NET_LOCK_GIANT() when entering network code.
>   

Do other drivers do this?  It looks like at least em, fxp
and my out-of-tree commercial driver have the same "bug".

I would argue that any fiddling with Giant should go into
the various if_input routines instead.

Drew