From owner-cvs-all@FreeBSD.ORG  Tue Feb 15 22:17:07 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ED0B016A4CE; Tue, 15 Feb 2005 22:17:07 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D6FAB43D49; Tue, 15 Feb 2005 22:17:07 +0000 (GMT)
	(envelope-from bmilekic@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j1FMH72f054658;
	Tue, 15 Feb 2005 22:17:07 GMT
	(envelope-from bmilekic@repoman.freebsd.org)
Received: (from bmilekic@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j1FMH7Qf054657;
	Tue, 15 Feb 2005 22:17:07 GMT
	(envelope-from bmilekic)
Message-Id: <200502152217.j1FMH7Qf054657@repoman.freebsd.org>
From: Bosko Milekic <bmilekic@FreeBSD.org>
Date: Tue, 15 Feb 2005 22:17:07 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/vm memguard.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Feb 2005 22:17:08 -0000

bmilekic    2005-02-15 22:17:07 UTC

  FreeBSD src repository

  Modified files:
    sys/vm               memguard.c 
  Log:
  Rather than overloading the page->object field like UMA does, use instead
  an unused pageq queue reference in the page structure to stash a pointer
  to the MemGuard FIFO.  Using the page->object field caused problems
  because when vm_map_protect() was called the second time to set
  VM_PROT_DEFAULT back onto a set of pages in memguard_map, the protection
  in the VM would be changed but the PMAP code would lazily not restore
  the PG_RW bit on the underlying pages right away (see pmap_protect()).
  So when a page fault finally occured and the VM noticed the faulting
  address corresponds to a page that _does_ have write access now, it
  would then call into PMAP to set back PG_RW (i386 case being discussed
  here).  However, before it got to do that, an assertion on the object
  lock not being owned would get triggered, as the object of the faulting
  page would need to be locked but was overloaded by MemGuard.  This is
  precisely why MemGuard cannot overload page->object.
  
  Submitted by: Alan Cox (alc@)
  
  Revision  Changes    Path
  1.4       +13 -17    src/sys/vm/memguard.c