Date: Fri, 14 Dec 2012 13:08:02 GMT From: Ruslan Makhmatkhanov <rm@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/174430: sysutils/gnome-system-tools: fix build with clang Message-ID: <201212141308.qBED82We002571@red.freebsd.org> Resent-Message-ID: <201212141310.qBEDA050053168@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 174430
>Category: ports
>Synopsis: sysutils/gnome-system-tools: fix build with clang
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 14 13:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Ruslan Makhmatkhanov
>Release: 10.0-CURRENT
>Organization:
>Environment:
10.0-CURRENT amd64
>Description:
Build fails with clang (3.2 (trunk 162107))
network-locations.c:1141:3: error: void function 'gst_network_locations_delete_location' should not return a value [-Wreturn-type]
g_return_val_if_fail (GST_IS_NETWORK_LOCATIONS (locations), FALSE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/glib-2.0/glib/gmessages.h:273:3: note: expanded from macro 'g_return_val_if_fail'
return (val); \
^ ~~~~~
1 error generated.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: files/patch-src-network_network-locations.c
===================================================================
--- files/patch-src-network_network-locations.c (revision 0)
+++ files/patch-src-network_network-locations.c (working copy)
@@ -0,0 +1,11 @@
+--- ./src/network/network-locations.c.orig 2010-05-24 21:09:57.000000000 +0400
++++ ./src/network/network-locations.c 2012-12-14 16:44:29.000000000 +0400
+@@ -1131,7 +1131,7 @@
+ return result;
+ }
+
+-void
++gboolean
+ gst_network_locations_delete_location (GstNetworkLocations *locations,
+ const gchar *name)
+ {
Property changes on: files/patch-src-network_network-locations.c
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: files/patch-src-network_network-locations.h
===================================================================
--- files/patch-src-network_network-locations.h (revision 0)
+++ files/patch-src-network_network-locations.h (working copy)
@@ -0,0 +1,11 @@
+--- ./src/network/network-locations.h.orig 2010-05-24 21:09:57.000000000 +0400
++++ ./src/network/network-locations.h 2012-12-14 16:47:54.000000000 +0400
+@@ -62,7 +62,7 @@
+ const gchar *name);
+ gboolean gst_network_locations_save_current (GstNetworkLocations *locations,
+ const gchar *name);
+-void gst_network_locations_delete_location (GstNetworkLocations *locations,
++gboolean gst_network_locations_delete_location (GstNetworkLocations *locations,
+ const gchar *name);
+
+ G_END_DECLS
Property changes on: files/patch-src-network_network-locations.h
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212141308.qBED82We002571>