Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Dec 2015 10:58:51 +0000 (UTC)
From:      Raphael Kubo da Costa <rakuco@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r402818 - in head/devel: cmake-gui/files cmake/files
Message-ID:  <201512021058.tB2AwpJp041502@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rakuco
Date: Wed Dec  2 10:58:50 2015
New Revision: 402818
URL: https://svnweb.freebsd.org/changeset/ports/402818

Log:
  CMake: Add upstream patch to fix the build with recent GCCs.
  
  At least lang/gcc (4.8) and later were known to be broken like this:
  
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:93:23: error: 'mode_t' has not been declared
     void SetPermissions(mode_t permissions_)
                         ^
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:106:27: error: 'mode_t' has not been declared
     void SetPermissionsMask(mode_t permissionsMask_)
                             ^
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:179:26: error: 'mode_t' was not declared in this scope
     cmArchiveWriteOptional<mode_t> Permissions;
                            ^
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:179:32: error: template argument 1 is invalid
     cmArchiveWriteOptional<mode_t> Permissions;
                                  ^
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:180:26: error: 'mode_t' was not declared in this scope
     cmArchiveWriteOptional<mode_t> PermissionsMask;
                            ^
  /usr/ports/devel/cmake/work/cmake-3.4.0/Source/cmArchiveWrite.h:180:32: error: template argument 1 is invalid
     cmArchiveWriteOptional<mode_t> PermissionsMask;
                                  ^
  
  This was introduced in CMake 3.4.0, so there is no need for an MFH request.
  
  PR:		204921

Added:
  head/devel/cmake-gui/files/patch-git_16f5d184   (contents, props changed)
  head/devel/cmake/files/patch-git_16f5d184   (contents, props changed)

Added: head/devel/cmake-gui/files/patch-git_16f5d184
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/cmake-gui/files/patch-git_16f5d184	Wed Dec  2 10:58:50 2015	(r402818)
@@ -0,0 +1,22 @@
+Fixes the build with recent GCCs (at least 4.8+).
+
+commit 16f5d1843b3720729f50376f522550fcfa787a3c
+Author: Kylie McClain <somasissounds@gmail.com>
+Date:   Wed Nov 25 18:12:06 2015 -0500
+
+    Include `sys/types.h` header to get `mode_t`
+
+    Do not depend on it being included by other system headers.
+    It is not included by others on musl-libc, for example.
+
+--- Source/cmStandardIncludes.h
++++ Source/cmStandardIncludes.h
+@@ -54,6 +54,8 @@
+ 
+ #if defined( _MSC_VER )
+ typedef unsigned short mode_t;
++#else
++# include <sys/types.h>
+ #endif
+ 
+ // use this class to shrink the size of symbols in .o files

Added: head/devel/cmake/files/patch-git_16f5d184
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/cmake/files/patch-git_16f5d184	Wed Dec  2 10:58:50 2015	(r402818)
@@ -0,0 +1,22 @@
+Fixes the build with recent GCCs (at least 4.8+).
+
+commit 16f5d1843b3720729f50376f522550fcfa787a3c
+Author: Kylie McClain <somasissounds@gmail.com>
+Date:   Wed Nov 25 18:12:06 2015 -0500
+
+    Include `sys/types.h` header to get `mode_t`
+
+    Do not depend on it being included by other system headers.
+    It is not included by others on musl-libc, for example.
+
+--- Source/cmStandardIncludes.h
++++ Source/cmStandardIncludes.h
+@@ -54,6 +54,8 @@
+ 
+ #if defined( _MSC_VER )
+ typedef unsigned short mode_t;
++#else
++# include <sys/types.h>
+ #endif
+ 
+ // use this class to shrink the size of symbols in .o files



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512021058.tB2AwpJp041502>