From owner-svn-src-head@FreeBSD.ORG Sat Jul 13 11:18:34 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9EC11EBC; Sat, 13 Jul 2013 11:18:34 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) by mx1.freebsd.org (Postfix) with ESMTP id 5A1E11B2E; Sat, 13 Jul 2013 11:18:33 +0000 (UTC) Received: by mail-lb0-f171.google.com with SMTP id 13so8203796lba.2 for ; Sat, 13 Jul 2013 04:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Moa+Yt8826etSzMwVRCHyl7jFZ4n40T00bKxslnZMs8=; b=KaegsC3tZP9zE5c+/mJ9ngxt7Ap5ouiUxObMPck3y4BK4YfYGBixVHRomIclm1ZWy5 9eMtSzJIJWKrs6emyGRLrhMp30FXYscc5xNf+NSXQfbRjrdXZM3IHxGEukBt+tOTJmzy mZNqmMqJ7Exw9WvQWBeNHcLaGYjYjzFJiTixGUyyDC1L3jVdOCU6nudSC2GvH3iZmdqd MDs0PJpAbqMPcz6x1HhJnHTp6954SwvZD0N06kiQr88X3RoSvuYFqDZaVaKrHa8CBj2I Nws0v9j/hQXqOpaNjXNyigjs/y5D331gQPdJur7svpf8smIcHWCEE/QxFympdygQFAYP NYcQ== X-Received: by 10.112.53.10 with SMTP id x10mr21092170lbo.28.1373714310633; Sat, 13 Jul 2013 04:18:30 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id e5sm15298086lbw.3.2013.07.13.04.18.28 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 04:18:29 -0700 (PDT) Sender: Mikolaj Golub Date: Sat, 13 Jul 2013 14:18:26 +0300 From: Mikolaj Golub To: Craig Rodrigues Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713111825.GE2757@gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <20130712202710.GB2757@gmail.com> <20130713073118.GC2757@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd , src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 11:18:34 -0000 On Sat, Jul 13, 2013 at 03:31:34AM -0700, Craig Rodrigues wrote: > > I experimented with Marko's patch, and found that the kernel crashed > inside the code which initializes PF. .... > /usr/home/rodrigc/freebsd/9/sys/modules/pf/../../contrib/pf/net/pf_ioctl.c:295 > 295 { > (kgdb) l > 290 > 291 mtx_destroy(&pf_task_mtx); > 292 } > 293 void > 294 init_zone_var(void) > 295 { > 296 V_pf_src_tree_pl = V_pf_rule_pl = NULL; > 297 V_pf_state_pl = V_pf_state_key_pl = V_pf_state_item_pl = > NULL; > 298 V_pf_altq_pl = V_pf_pooladdr_pl = NULL; > 299 V_pf_frent_pl = V_pf_frag_pl = V_pf_cache_pl = V_pf_cent_pl > = NULL; > > In init_zone_var(), curthread->td_vnet was NULL. I wonder if it fails on current too? It looks this code is not there any more. I will try. > So, I don't think it is safe to remove the vnet stuff from > kldload/kldunload just yet, > without fixing some code in some kernel modules like PF. > If you have plans to merge the changes to stable then yes, I think it is safer to commit the patch without kldload/kldunload part and commit the last separately after testing (and fixing affected modules if there are). > The other parts of the patch look OK. So it works for you with your commit reverted and without Adrians' netgraph patch? -- Mikolaj Golub