From owner-freebsd-current@FreeBSD.ORG  Sat Apr 10 11:48:21 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ECC2F16A4CE
	for <current@freebsd.org>; Sat, 10 Apr 2004 11:48:21 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 59E8243D39
	for <current@freebsd.org>; Sat, 10 Apr 2004 11:48:21 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i3AImCnl011274;
	Sat, 10 Apr 2004 20:48:13 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: noackjr@alumni.rice.edu
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 10 Apr 2004 12:54:14 CDT."
             <1747.192.168.1.9.1081619654.squirrel@www.noacks.org> 
Date: Sat, 10 Apr 2004 20:48:12 +0200
Message-ID: <11273.1081622892@critter.freebsd.dk>
cc: current@freebsd.org
cc: Putinas Piliponis <putinas.piliponis@icnspot.net>
Subject: Re: LOR: sys/kern/sys_generic.c:902 sys/fs/specfs/spec_vnops.c:387 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 18:48:22 -0000

In message <1747.192.168.1.9.1081619654.squirrel@www.noacks.org>, "Jon Noack" w
rites:

Can you try this workaround ?

Index: spec_vnops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/specfs/spec_vnops.c,v
retrieving revision 1.220
diff -u -r1.220 spec_vnops.c
--- spec_vnops.c	7 Apr 2004 20:46:02 -0000	1.220
+++ spec_vnops.c	10 Apr 2004 18:47:32 -0000
@@ -382,9 +382,9 @@
 	    ("spec_poll() on un-referenced dev_t (%s)", devtoname(dev)));
 	cdevsw_ref(dsw);
 	if (!(dsw->d_flags & D_NEEDGIANT)) {
-		DROP_GIANT();
+		/* XXX: not yet DROP_GIANT(); */
 		error = dsw->d_poll(dev, ap->a_events, ap->a_td);
-		PICKUP_GIANT();
+		/* XXX: not yet PICKUP_GIANT(); */
 	} else
 		error = dsw->d_poll(dev, ap->a_events, ap->a_td);
 	cdevsw_rel(dsw);

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.