Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Jun 2020 14:40:08 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Mateusz Piotrowski <0mp@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r539975 - in head/x11-themes: . slim-freebsd-dark-theme
Message-ID:  <20200623124008.ym2jyppfullh756a@ivaldir.net>
In-Reply-To: <202006231225.05NCPGsL001130@repo.freebsd.org>
References:  <202006231225.05NCPGsL001130@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--kr63j7a2vjdgw4wo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 23, 2020 at 12:25:16PM +0000, Mateusz Piotrowski wrote:
> Author: 0mp
> Date: Tue Jun 23 12:25:16 2020
> New Revision: 539975
> URL: https://svnweb.freebsd.org/changeset/ports/539975
>=20
> Log:
>   New port: x11-themes/slim-freebsd-dark-theme
>  =20
>   SLiM is an acronym for "Simple Login Manager".
>  =20
>   Lightweight and easily configurable, SLiM requires minimal dependencies,
>   and none from the GNOME or KDE desktop environments. It therefore
>   contributes towards a lightweight system for users that also like to use
>   lightweight desktops such as Xfce, Openbox, and Fluxbox.
>  =20
>   This package is a minimalist FreeBSD black/red colors theme, using
>   the colors defined by the FreeBSD Foundation.
>  =20
>   WWW: https://github.com/gocobachi/slim-freebsd-dark-theme
>  =20
>   PR:		247490
>   Submitted by:	Miguel Gocobachi <miguel@gocobachi.mx>
>   Differential Revision:	https://reviews.freebsd.org/D25410
>=20
> Added:
>   head/x11-themes/slim-freebsd-dark-theme/
>   head/x11-themes/slim-freebsd-dark-theme/Makefile   (contents, props cha=
nged)
>   head/x11-themes/slim-freebsd-dark-theme/distinfo   (contents, props cha=
nged)
>   head/x11-themes/slim-freebsd-dark-theme/pkg-descr   (contents, props ch=
anged)
> Modified:
>   head/x11-themes/Makefile
>=20
> Modified: head/x11-themes/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/x11-themes/Makefile	Tue Jun 23 12:14:51 2020	(r539974)
> +++ head/x11-themes/Makefile	Tue Jun 23 12:25:16 2020	(r539975)
> @@ -141,6 +141,7 @@
>      SUBDIR +=3D sddm-freebsd-black-theme
>      SUBDIR +=3D sierra-gtk-themes
>      SUBDIR +=3D slim-freebsd-black-theme
> +    SUBDIR +=3D slim-freebsd-dark-theme
>      SUBDIR +=3D slim-freebsd-themes
>      SUBDIR +=3D slim-themes
>      SUBDIR +=3D thewidgetfactory
>=20
> Added: head/x11-themes/slim-freebsd-dark-theme/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/Makefile	Tue Jun 23 12:25:16 =
2020	(r539975)
> @@ -0,0 +1,33 @@
> +# $FreeBSD$
> +
> +PORTNAME=3D	slim-freebsd-dark-theme
> +DISTVERSIONPREFIX=3D	v
> +DISTVERSION=3D	1.0
> +CATEGORIES=3D	x11-themes
> +
> +MAINTAINER=3D	miguel@gocobachi.dev
> +COMMENT=3D	Minimalist FreeBSD black/red colors theme for SLiM
> +
> +LICENSE=3D	BSD2CLAUSE
> +LICENSE_FILE=3D	${WRKSRC}/LICENSE
> +
> +USE_GITHUB=3D	yes
> +GH_ACCOUNT=3D	gocobachi
> +
> +NO_ARCH=3D	yes
> +NO_BUILD=3D	yes
> +
> +PLIST_FILES=3D	${_THEMEDIR_REL}/background.png \
> +		${_THEMEDIR_REL}/panel.png \
> +		${_THEMEDIR_REL}/screenshot.png \
> +		${_THEMEDIR_REL}/slim.theme
> +
> +_THEMEDIR_REL=3D	share/slim/themes/slim-freebsd-dark-theme
> +_THEMEDIR=3D	${PREFIX}/${_THEMEDIR_REL}
> +
> +do-install:
> +	@${MKDIR} ${STAGEDIR}${_THEMEDIR}
> +	(cd ${WRKSRC} && \
> +		${COPYTREE_SHARE} . ${STAGEDIR}${_THEMEDIR} '! -name LICENSE ! -name R=
EADME.md')

Won't it be easier to just INSTALL_DATA *.png *.theme ${STAGEDIR}${_THEMEDI=
R}
easier to read, easier to understand (and less resources consuming)

> +
> +.include <bsd.port.mk>
>=20
> Added: head/x11-themes/slim-freebsd-dark-theme/distinfo
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/distinfo	Tue Jun 23 12:25:16 =
2020	(r539975)
> @@ -0,0 +1,3 @@
> +TIMESTAMP =3D 1592911411
> +SHA256 (gocobachi-slim-freebsd-dark-theme-v1.0_GH0.tar.gz) =3D ab5c75bda=
bb3621df5815998fbb56747c0861c0b43857be657802de059c8889c
> +SIZE (gocobachi-slim-freebsd-dark-theme-v1.0_GH0.tar.gz) =3D 72948
>=20
> Added: head/x11-themes/slim-freebsd-dark-theme/pkg-descr
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/pkg-descr	Tue Jun 23 12:25:16=
 2020	(r539975)
> @@ -0,0 +1,11 @@
> +SLiM is an acronym for "Simple Login Manager".
> +
> +Lightweight and easily configurable, SLiM requires minimal dependencies,
> +and none from the GNOME or KDE desktop environments. It therefore contri=
butes
> +towards a lightweight system for users that also like to use lightweight
> +desktops such as Xfce, Openbox, and Fluxbox.
> +
> +This package is a minimalist FreeBSD black/red colors theme, using
> +the colors defined by the FreeBSD Foundation.

I think this descripton should be rewritten:

The first part explain what slim is, imho this is useless this is redundant=
 with
the slim package description.

I would trim the description to something like:
Minimalist FreeBSD black/red colors theme for the SLIM Login Manager, using=
 the
colors defined by the FreeBSD Foundation.

WWW: https://github.com/gocobachi/slim-freebsd-dark-theme

--kr63j7a2vjdgw4wo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl7x+CgACgkQY4mL3PG3
PlorVRAA2t4RE+NAc12ZIf3zSOukHxwX1Uvxxt5gp/EVDGUixUV1F4Rt/dKewedR
2wGWGOTgecQbw4O13A9MMJRQ3g73Q98ZX9By6e4HOkJmp67NaMIsJEP57XppRLJK
kI1LWcmkfXY1sJ6UiMzWUSWrpBquUwoK7WhVLrossF1Mn7JLlxZqEM6X0HAFYO8u
j0V8Z5GLyU5x4iBe93aqW3e9zFIcJpl7MsjE4kDzXUdNH3Vs/6NcATMiXSJicqFo
3tS+3vBQKcA13OwXdN4lg9uMlOsBjCPasNuCeDC/oMY17g56qkj8A39ReP1QvB/E
WMbSgQRF1O26mR43D/me8xvfJrgSXfvSYgM8s/Q1vrrnOn1zTIoDpeSixP+U2ndu
lChRZBgU+u+RHqxJhGhG4/ZpkD3hyYNBQD9RpShAEroTecByUoCSPc8Lg4Pgl41l
SJYtuhUy4rlrqvQGm+c9xuu/ziuw4JjbHmluLHd993zVHrxGAtLp1rSP3oIRs4MS
+QfVIlE0RPbqy4x/YOMKI9qj12oqI4yITrtzW82CQl3YMrep8zztWAt8/lH4lzoF
ubkjZ74a+fSlzNFZcUAwEsRjzWxnKclgUpfNdbglux4g0cO/oNOdPHrLy1/cuGw8
wJPKP9q00eqwuslAiMQqMvoArdSBNWbIcQTbcopknjORBEP4Ebs=
=tEd8
-----END PGP SIGNATURE-----

--kr63j7a2vjdgw4wo--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200623124008.ym2jyppfullh756a>