From owner-freebsd-current@FreeBSD.ORG  Fri Jun 11 11:16:40 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3C11616A4D0
	for <current@FreeBSD.org>; Fri, 11 Jun 2004 11:16:40 +0000 (GMT)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 51C5E43D41
	for <current@FreeBSD.org>; Fri, 11 Jun 2004 11:16:39 +0000 (GMT)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i5BBG94u004092;	Fri, 11 Jun 2004 21:16:10 +1000
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i5BBG6LS005187;	Fri, 11 Jun 2004 21:16:08 +1000
Date: Fri, 11 Jun 2004 21:16:06 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <69020.1086934568@critter.freebsd.dk>
Message-ID: <20040611210929.J13443@gamplex.bde.org>
References: <69020.1086934568@critter.freebsd.dk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@FreeBSD.org
Subject: Re: kernel dev_t elimination patch for review
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2004 11:16:40 -0000

On Fri, 11 Jun 2004, Poul-Henning Kamp wrote:

> 	http://phk.freebsd.dk/patch/dev_t.patch
>
> This patch changes "dev_t" in the kernel to "struct cdev *"
> and is 337K of boredom like:
>
> 	-static dev_t perfdev;
> 	+static struct cdev *perfdev;
>
> People who maintain cross-platform or cross-version source code in
> the kernel, should take a close look at this patch.
>
> If you don't like the way I have done it (which is mostly automated)
> you are more than welcome to commit your own patch, all you have
> to do is use "struct cdev *" instead of "dev_t", and you can do
> that already now.

This mangles the formatting in approximately 10% of cases (mainly for
dev_t\t\t and for almost all dev_t's in structs; in structs it tends
to misindent both the member name and the comment).

Bruce