Date: Wed, 31 Jan 2024 13:59:41 -0700 From: Warner Losh <imp@bsdimp.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Andriy Gapon <avg@freebsd.org>, Jung-uk Kim <jkim@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, Dmitry Salychev <dsl@mcusim.org> Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 Message-ID: <CANCZdfqVe%2BMGM846HPnMdHP=hhy6mKK2VHagzZ9R9p4C7JZgXA@mail.gmail.com> In-Reply-To: <20240131204355.9EA2B19F@slippy.cwsent.com> References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> <20240131204355.9EA2B19F@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000560d10610442914 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert <Cy.Schubert@cschubert.co= m> wrote: > In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy > Gapon > wri > tes: > > On 31/01/2024 19:40, Cy Schubert wrote: > > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, > Jung-uk Kim > > > writ > > > es: > > >> On 24. 1. 31., Baptiste Daroussin wrote: > > >>> Hello, > > >>> > > >>> Either this one or the previous import is breaking arm64 build > > >>> > > >>> --- acpi_iort.o --- > > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error= : > fiel > > d > > >>> 'data' with variable sized type 'union (unnamed union at > > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 > > >>> )' not at the end of a struct or class is a GNU extension > > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] > > >>> 103 | } data; > > >>> | ^ > > >> > > >> Sorry for the breakage. I will fix it soon. > > >> > > >> BTW, this code was added by this: > > >> > > >> https://reviews.freebsd.org/D31267 > > >> > > >> It seems struct iort_named_component was a hack, which duplicated > > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field > DeviceName[32]. > > >> Is it really necessary? > > > > > > Though they incorporated the WOL patch I've been using, they've broke= n > > > poweroff. > > > > The poweroff issue could be because of 9cdf326b4f > > Thanks. I clued into that a while ago after taking a break to read the ML= . > > This smelled of the original WOL problem I had last year that required > pulling the plug to allow the NIC to see the magic packet, but worse. > Hence > I was barking up the wrong tree. > On an semi-related issue... mind if I do a proper merge commit to catch up and not leave hidden landmines for the future? Warner > > -- > Cheers, > Cy Schubert <Cy.Schubert@cschubert.com> > FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org > NTP: <cy@nwtime.org> Web: https://nwtime.org > > e^(i*pi)+1=3D0 > > > --0000000000000560d10610442914 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert <= <a href=3D"mailto:Cy.Schubert@cschubert.com">Cy.Schubert@cschubert.com</a>&= gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0= .8ex;border-left:1px #ccc solid;padding-left:1ex">In message <737703f2-= 26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy Gapon <br> wri<br> tes:<br> > On 31/01/2024 19:40, Cy Schubert wrote:<br> > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org&g= t;, Jung-uk Kim<br> > > writ<br> > > es:<br> > >> On 24. 1. 31., Baptiste Daroussin wrote:<br> > >>> Hello,<br> > >>><br> > >>> Either this one or the previous import is breaking arm64 = build<br> > >>><br> > >>> --- acpi_iort.o ---<br> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:10= 3:4: error: fiel<br> > d<br> > >>> 'data' with variable sized type 'union (unnam= ed union at<br> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98= :2<br> > >>> )' not at the end of a struct or class is a GNU exten= sion<br> > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end]<br> > >>>=C2=A0 =C2=A0 =C2=A0103 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0} data;<br> > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br> > >><br> > >> Sorry for the breakage.=C2=A0 I will fix it soon.<br> > >><br> > >> BTW, this code was added by this:<br> > >><br> > >> <a href=3D"https://reviews.freebsd.org/D31267" rel=3D"norefer= rer noreferrer" target=3D"_blank">https://reviews.freebsd.org/D31267</a><br= > > >><br> > >> It seems struct iort_named_component was a hack, which duplic= ated<br> > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field Devic= eName[32].<br> > >> Is it really necessary?<br> > > <br> > > Though they incorporated the WOL patch I've been using, they&= #39;ve broken<br> > > poweroff.<br> ><br> > The poweroff issue could be because of 9cdf326b4f<br> <br> Thanks. I clued into that a while ago after taking a break to read the ML.<= br> <br> This smelled of the original WOL problem I had last year that required <br> pulling the plug to allow the NIC to see the magic packet, but worse. Hence= <br> I was barking up the wrong tree.<br></blockquote></div></div><div dir=3D"au= to"><br></div><div dir=3D"auto">On an semi-related issue... mind if I do a = proper merge commit to catch up and not leave hidden landmines for the futu= re?</div><div dir=3D"auto"><br></div><div dir=3D"auto">Warner</div><div dir= =3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" styl= e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> -- <br> Cheers,<br> Cy Schubert <<a href=3D"mailto:Cy.Schubert@cschubert.com" target=3D"_bla= nk" rel=3D"noreferrer">Cy.Schubert@cschubert.com</a>><br> FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a href= =3D"https://FreeBSD.org" rel=3D"noreferrer noreferrer" target=3D"_blank">ht= tps://FreeBSD.org</a><br> NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<<a href=3D"mailto:cy@nwtim= e.org" target=3D"_blank" rel=3D"noreferrer">cy@nwtime.org</a>>=C2=A0 =C2= =A0 Web:=C2=A0 <a href=3D"https://nwtime.org" rel=3D"noreferrer noreferrer"= target=3D"_blank">https://nwtime.org</a><br>; <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 e^(i*pi)+1=3D0<br> <br> <br> </blockquote></div></div></div> --0000000000000560d10610442914--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqVe%2BMGM846HPnMdHP=hhy6mKK2VHagzZ9R9p4C7JZgXA>