From owner-freebsd-ports-bugs@FreeBSD.ORG Thu May 20 10:50:01 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E50C106564A for ; Thu, 20 May 2010 10:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 503F48FC14 for ; Thu, 20 May 2010 10:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4KAo1jS011161 for ; Thu, 20 May 2010 10:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4KAo1M5011160; Thu, 20 May 2010 10:50:01 GMT (envelope-from gnats) Resent-Date: Thu, 20 May 2010 10:50:01 GMT Resent-Message-Id: <201005201050.o4KAo1M5011160@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mike Makonnen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E372106564A for ; Thu, 20 May 2010 10:48:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 1D9A98FC19 for ; Thu, 20 May 2010 10:48:56 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4KAmtAf027697 for ; Thu, 20 May 2010 10:48:55 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o4KAmtkT027696; Thu, 20 May 2010 10:48:55 GMT (envelope-from nobody) Message-Id: <201005201048.o4KAmtkT027696@www.freebsd.org> Date: Thu, 20 May 2010 10:48:55 GMT From: Mike Makonnen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/146752: VirtualBox assertion: Lock/Unlock is not implemented X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2010 10:50:01 -0000 >Number: 146752 >Category: ports >Synopsis: VirtualBox assertion: Lock/Unlock is not implemented >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu May 20 10:50:00 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Mike Makonnen >Release: FreeBSD 9-CURRENT >Organization: >Environment: FreeBSD rogue.mike.lan 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r208116: Sat May 15 23:38:15 EAT 2010 mtm@rogue.mike.lan:/data/build/obj/data/build/src/sys/ROGUE amd64 >Description: When trying to install Windows XP SP2 as a guest OS from the hosts DVD drive the following assertion is triggered right after the setup program finishes loading drivers: Lock/Unlock is not implemented. I noticed this after the recent upgrade to VirtualBox 3.1.8. I also did a world and kernel upgrade in the mean time so I'm not sure if that may have had something to do with it. The Host is a 9-Current amd64 box. >How-To-Repeat: Try to install Windows XP as a guest OS from a DVD Drive. >Fix: The problem is a missing compile time #define that makes it think FreeBSD doesn't support locking of the DVD drive door. The attached patch fixes the problem for me. Patch attached with submission follows: --- src/VBox/Devices/Storage/DrvHostDVD.cpp.orig 2010-05-20 10:28:06.000000000 +0300 +++ src/VBox/Devices/Storage/DrvHostDVD.cpp 2010-05-20 10:37:47.000000000 +0300 @@ -224,7 +224,7 @@ */ static DECLCALLBACK(int) drvHostDvdDoLock(PDRVHOSTBASE pThis, bool fLock) { -#ifdef RT_OS_DARWIN +#if defined(RT_OS_FREEBSD) || defined(RT_OS_DARWIN) uint8_t abCmd[16] = { SCSI_PREVENT_ALLOW_MEDIUM_REMOVAL, 0, 0, 0, fLock, 0, >Release-Note: >Audit-Trail: >Unformatted: