From owner-freebsd-hackers@FreeBSD.ORG Tue Apr 7 19:16:33 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0458106566B for ; Tue, 7 Apr 2009 19:16:33 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-qy0-f134.google.com (mail-qy0-f134.google.com [209.85.221.134]) by mx1.freebsd.org (Postfix) with ESMTP id 581B98FC14 for ; Tue, 7 Apr 2009 19:16:33 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by qyk40 with SMTP id 40so4979050qyk.3 for ; Tue, 07 Apr 2009 12:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=fq9mM/VD2b5OfbyGtxqkbkgih9evWUpPpCi1/pmUHqM=; b=uNxSl16p2T8HBZm19yzto/jIhptGhPj94+oDHhQAmjoeEHNzOxgBJ0zf6DTYLo+ae8 LDfDNJISMMzeTbBmd53EAVrBuCo0QYFccCZ7eJf40/r3Fu56pFGCum2KNFWm8guGUnKb mroSy4alGb+lzI1j1dZD0en9xOyPntbah7vLc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=JqAKT9ryp/2VKUIap4dHhrFy+vkWj3MWJoLzNGV9yZnECXYzChtfn3lZ5uzmZ3+BSI 9rWsPbW8iWF5oa/DUj2frLi3DrZWKWtcX6IeZNXwxWRNAyGRBWq55eWFoLXJi7oaQv4r OaJahw8E4FDgBzFjcAjpFDr5yEipELsll2aWY= MIME-Version: 1.0 Received: by 10.220.45.205 with SMTP id g13mr872241vcf.64.1239131792506; Tue, 07 Apr 2009 12:16:32 -0700 (PDT) Date: Tue, 7 Apr 2009 12:16:32 -0700 Message-ID: From: Navdeep Parhar To: FreeBSD Hackers Content-Type: multipart/mixed; boundary=0016364ec8685281e50466fbda97 Subject: KLDs missing CTF information (patch attached) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 19:16:34 -0000 --0016364ec8685281e50466fbda97 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit It appears that the KLD build process is missing a ctfmerge at the end, and this results in KLDs with incomplete CTF information. Here is a patch that fixes this. I verified it on amd64 with various KLDs. Before: # ctfdump /boot/kernel/if_cxgb.ko | wc -l 2269 # ctfdump /boot/kernel/zfs.ko | wc -l 430 After: # ctfdump /boot/kernel/if_cxgb.ko | wc -l 6568 # ctfdump /boot/kernel/zfs.ko | wc -l 15032 It is wasteful to have CTF information in both the .ko and the .ko.symbols file but this is what the kernel does too. Regards, Navdeep --0016364ec8685281e50466fbda97 Content-Type: application/octet-stream; name="ctf-kld.patch" Content-Disposition: attachment; filename="ctf-kld.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ft8yyxoz0 ZGlmZiAtciBiM2Y0ZTZhODJhODYgc3lzL2NvbmYva21vZC5tawotLS0gYS9zeXMvY29uZi9rbW9k Lm1rCU1vbiBBcHIgMDYgMTM6NDc6MzkgMjAwOSAtMDcwMAorKysgYi9zeXMvY29uZi9rbW9kLm1r CVR1ZSBBcHIgMDcgMTI6MDA6NTIgMjAwOSAtMDcwMApAQCAtMTI4LDYgKzEyOCwxMCBAQAogQ0ZM QUdTKz0JLW1sb25nY2FsbCAtZm5vLW9taXQtZnJhbWUtcG9pbnRlcgogLmVuZGlmCiAKKy5pZiBk ZWZpbmVkKERFQlVHKSB8fCBkZWZpbmVkKERFQlVHX0ZMQUdTKQorQ1RGRkxBR1MrPQktZworLmVu ZGlmCisKIC5pZiBkZWZpbmVkKEZJUk1XUykKIC5pZiAhZXhpc3RzKEApCiAke0tNT0Q6Uy8kLy5j L306IEAKQEAgLTE5Myw2ICsxOTcsOSBAQAogJHtGVUxMUFJPR306ICR7T0JKU30KIC5lbmRpZgog CSR7TER9ICR7TERGTEFHU30gLXIgLWQgLW8gJHsuVEFSR0VUfSAke09CSlN9CisuaWYgZGVmaW5l ZChDVEZNRVJHRSkKKwkke0NURk1FUkdFfSAke0NURkZMQUdTfSAtbyAkey5UQVJHRVR9ICR7T0JK U30KKy5lbmRpZgogLmlmIGRlZmluZWQoRVhQT1JUX1NZTVMpCiAuaWYgJHtFWFBPUlRfU1lNU30g IT0gWUVTCiAuaWYgJHtFWFBPUlRfU1lNU30gPT0gTk8K --0016364ec8685281e50466fbda97--