From owner-freebsd-emulation@FreeBSD.ORG Sun Nov 17 21:40:01 2013 Return-Path: Delivered-To: vbox@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D03E339C for ; Sun, 17 Nov 2013 21:40:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C02AB2658 for ; Sun, 17 Nov 2013 21:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAHLe1ZW009780 for ; Sun, 17 Nov 2013 21:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAHLe1RO009779; Sun, 17 Nov 2013 21:40:01 GMT (envelope-from gnats) Date: Sun, 17 Nov 2013 21:40:01 GMT Message-Id: <201311172140.rAHLe1RO009779@freefall.freebsd.org> To: vbox@FreeBSD.org From: Eitan Adler Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose X-Mailman-Approved-At: Sun, 17 Nov 2013 21:51:32 +0000 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Eitan Adler List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 21:40:01 -0000 The following reply was made to PR ports/182468; it has been noted by GNATS. From: Eitan Adler To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= , bug-followup , Peter Jeremy Cc: vbox@freebsd.org Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Date: Sun, 17 Nov 2013 16:32:46 -0500 On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fr=C3=B6hlich = wrote: > The following reply was made to PR ports/182468; it has been noted by GNA= TS. > > From: =3D?ISO-8859-1?Q?Bernhard_Fr=3DF6hlich?=3D > To: bug-followup@FreeBSD.org, peter@rulingia.com > Cc: > Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/v= irtualbox-ose > Date: Wed, 13 Nov 2013 13:31:49 +0100 > > I think the idea and approach is correct but I went for a slighly more > conservative > approach if _GCC_RUNTIME was not set which is true in case base gcc is u= sed=3D This can not possibly be correct as the variable begins with a "_". The initial proposed patch is also incorrect for a similar reason. _GCC_RUNTIME is not valid for use in a ports Makefile. Perhaps it would help if USE_GCC or USES=3Dcompiler exposed a variable indicating the runtime? --=20 Eitan Adler