From owner-freebsd-net@FreeBSD.ORG Wed Aug 22 00:12:32 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7644116A419 for ; Wed, 22 Aug 2007 00:12:32 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.freebsd.org (Postfix) with ESMTP id 0254F13C45A for ; Wed, 22 Aug 2007 00:12:31 +0000 (UTC) (envelope-from max@love2party.net) Received: from dslb-088-066-022-164.pools.arcor-ip.net [88.66.22.164] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis), id 0ML2xA-1INdg04BDm-00026U; Wed, 22 Aug 2007 02:02:25 +0200 From: Max Laier Organization: FreeBSD To: freebsd-net@freebsd.org Date: Wed, 22 Aug 2007 02:02:17 +0200 User-Agent: KMail/1.9.7 References: <20070821232956.GT87451@elvis.mu.org> In-Reply-To: <20070821232956.GT87451@elvis.mu.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1348266.DDDgb8NVuj"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200708220202.23004.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+QibD2haLEIsd07f8pPPmH7GJWH1J6L07KYfy a7/EJtLy98e81u1QhcLFA3n18nC6Db6J2teAF9cyA1YL8DV6xS 4XVh134JJe1CJ0w+KGPfyWABapaXLR27orfcIwq3nA= Cc: Alfred Perlstein Subject: Re: Allocating AF constants for vendors. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 00:12:32 -0000 --nextPart1348266.DDDgb8NVuj Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 22 August 2007, Alfred Perlstein wrote: > I trimmed the sender of this because I got it in private mail, that > said I thought it was a good bunch of questions so I am replying > to it. > > > 64? are you intending to bump AF_MAX or allocate them sequentially > > such that adding another AF will require AF_MAX to grow a lot? > > > > In general this seems like a bad idea to me. I suggest you need to > > (publicly) explain what you are doing and why this is a good idea. > > The goal here is to allow vendors to add their own constants without > worrying about conflicting with FreeBSD constants. It will allow > vendors to maintain some semblance of binary compatibility against > FreeBSD. > > If you look at libpcap: > > http://cvs.tcpdump.org/cgi-bin/cvsweb/libpcap/pcap/bpf.h?rev=3D1.15 > > You can see that Juniper has asked for some number of reserved > "families", in our case, I think it would be a bit greedy to > grow the list _just_ for Juniper, so I suggested something that > would work for every vendor. > > As far as implementation details, either one works for me, do you > have any particular preference? > > Other than the actual delta, will this have any noticeable negative > impact that you can see? DLTs are something very different to address families. DLTs are cheap as=20 they are simply a number that is passed around. In contrast to that,=20 there are some AF_MAX sized arrays in the kernel (e.g. if_afdata[] in=20 struct ifnet or the routing tables) these will grow if you change=20 AF_MAX - that's a bad thing! Could you provide a patch with what you have in mind so I (and other=20 similarly confused people) can understand what you have in mind. Extending AF_MAX by 64 is out of the question, IMHO. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1348266.DDDgb8NVuj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBGy30OXyyEoT62BG0RAjmMAJ0YXaeodrXZxB4UJ0Q2TIP87aKxGACfU0WT H2U6yTwii28tYwucnk1OfWs= =g2Na -----END PGP SIGNATURE----- --nextPart1348266.DDDgb8NVuj--