Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Sep 2012 21:46:36 -0400
From:      "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To:        Olli Hauer <ohauer@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r303982 - head/www/apache22
Message-ID:  <CACM2dAbyDNgqVxHSV7G=FCv6Egay9F8hM2km67g7OE4RUke4Og@mail.gmail.com>
In-Reply-To: <201209091701.q89H1UNl009740@svn.freebsd.org>
References:  <201209091701.q89H1UNl009740@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I don't know about this one.  Why should apache ports specifically point
you at the wiki.  The port system as a whole should do this, or every port
should (that would be a waste)
Please think about this some more.


On Sun, Sep 9, 2012 at 1:01 PM, Olli Hauer <ohauer@freebsd.org> wrote:

> Author: ohauer
> Date: Sun Sep  9 17:01:30 2012
> New Revision: 303982
> URL: http://svn.freebsd.org/changeset/ports/303982
>
> Log:
>   - notice the users that old WITH/WITHOUT parameters are obsolete.
>     Point them to the wiki
>
>   Thanks to crees@ for this suggestion to
>   implement this direct in the port
>
>   PR:           171509
>
> Modified:
>   head/www/apache22/Makefile
>
> Modified: head/www/apache22/Makefile
>
> ==============================================================================
> --- head/www/apache22/Makefile  Sun Sep  9 16:53:12 2012        (r303981)
> +++ head/www/apache22/Makefile  Sun Sep  9 17:01:30 2012        (r303982)
> @@ -47,6 +47,24 @@ WITH_HTTP_PORT?=     80
>  MPM_ITK_VERSION?=      20110321-01
>
>  .include "${APACHEDIR}/Makefile.options"
> +
> +# stop users from using old WITH/WITHOUT parameters
> +.for opt in ${OPTIONS_DEFINE}
> +.  if defined(WITH_${opt}) || defined(WITHOUT_${opt})
> +BROKEN=        WITH/WITHOUT parameters are obsolete. \
> +       The port use the new options NG framework. Please read\
> +       http://wiki.freebsd.org/Ports/Options/OptionsNG
> +.  endif
> +.endfor
> +
> +.for cat in ${ALL_MODULES_CATEGORIES}
> +.  if defined(WITH_${cat}_MODULES)
> +BROKEN=        WITH/WITHOUT_..._MODULES parameters are obsolete. \
> +       The port use the new options NG framework. Please read\
> +       http://wiki.freebsd.org/Ports/Options/OptionsNG
> +.  endif
> +.endfor
> +
>  .include <bsd.port.options.mk>
>  .include "${APACHEDIR}/Makefile.doc"
>
>


-- 
---------------------------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Director Operations,      Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACM2dAbyDNgqVxHSV7G=FCv6Egay9F8hM2km67g7OE4RUke4Og>