From owner-svn-ports-all@FreeBSD.ORG Thu Sep 13 01:46:37 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 858DF106566B for ; Thu, 13 Sep 2012 01:46:37 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 347878FC12 for ; Thu, 13 Sep 2012 01:46:37 +0000 (UTC) Received: by vcbfw7 with SMTP id fw7so3729328vcb.13 for ; Wed, 12 Sep 2012 18:46:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type:x-gm-message-state; bh=bahwqRx1Eu9wreKU2PvE0bdwFzVJEq6OPG3ICOrB8Sc=; b=Txjmld8TZ79gAVwwOx2K3EMpkupaWhb1aqwDybx2QC2QJWJxfDPwpSKzlsS9aWUa4N U3vZNdXTOKpIfM2J332FIz4aLX0NL1qEs0sYD7eSgBv8AlhvkxuwLeq/8jlZQEDoCCDE Ed5NCOJUkmq3Vi7Hgx9hH/KNlQaheElBhweAFA8X950lk5ZUkuMu9ZYMd+G+PO3d5Mb0 8bHEBUXccusZK8Cout3IBm8jrHCDmHIgUrq0bmOWGEIwNO1WURhl9wXYP8M2RqN3tZE4 ZFWohr/G3onIt3LsMl8A1prJae6ckIv+PaYWTaQXUGFImiagJ5sJxe3GJzXwjjmjN0BG 8kJg== MIME-Version: 1.0 Received: by 10.52.64.209 with SMTP id q17mr223207vds.32.1347500796410; Wed, 12 Sep 2012 18:46:36 -0700 (PDT) Received: by 10.58.186.228 with HTTP; Wed, 12 Sep 2012 18:46:36 -0700 (PDT) X-Originating-IP: [108.28.1.119] In-Reply-To: <201209091701.q89H1UNl009740@svn.freebsd.org> References: <201209091701.q89H1UNl009740@svn.freebsd.org> Date: Wed, 12 Sep 2012 21:46:36 -0400 Message-ID: From: "Philip M. Gollucci" To: Olli Hauer X-Gm-Message-State: ALoCoQnTIJiBDe9IMwgL/wLOwLrO1V4gfjkTqJcvgok1j9Fa+K0+bbRFijHzqA78uju4+lB+ddn6 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303982 - head/www/apache22 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2012 01:46:37 -0000 I don't know about this one. Why should apache ports specifically point you at the wiki. The port system as a whole should do this, or every port should (that would be a waste) Please think about this some more. On Sun, Sep 9, 2012 at 1:01 PM, Olli Hauer wrote: > Author: ohauer > Date: Sun Sep 9 17:01:30 2012 > New Revision: 303982 > URL: http://svn.freebsd.org/changeset/ports/303982 > > Log: > - notice the users that old WITH/WITHOUT parameters are obsolete. > Point them to the wiki > > Thanks to crees@ for this suggestion to > implement this direct in the port > > PR: 171509 > > Modified: > head/www/apache22/Makefile > > Modified: head/www/apache22/Makefile > > ============================================================================== > --- head/www/apache22/Makefile Sun Sep 9 16:53:12 2012 (r303981) > +++ head/www/apache22/Makefile Sun Sep 9 17:01:30 2012 (r303982) > @@ -47,6 +47,24 @@ WITH_HTTP_PORT?= 80 > MPM_ITK_VERSION?= 20110321-01 > > .include "${APACHEDIR}/Makefile.options" > + > +# stop users from using old WITH/WITHOUT parameters > +.for opt in ${OPTIONS_DEFINE} > +. if defined(WITH_${opt}) || defined(WITHOUT_${opt}) > +BROKEN= WITH/WITHOUT parameters are obsolete. \ > + The port use the new options NG framework. Please read\ > + http://wiki.freebsd.org/Ports/Options/OptionsNG > +. endif > +.endfor > + > +.for cat in ${ALL_MODULES_CATEGORIES} > +. if defined(WITH_${cat}_MODULES) > +BROKEN= WITH/WITHOUT_..._MODULES parameters are obsolete. \ > + The port use the new options NG framework. Please read\ > + http://wiki.freebsd.org/Ports/Options/OptionsNG > +. endif > +.endfor > + > .include > .include "${APACHEDIR}/Makefile.doc" > > -- --------------------------------------------------------------------------------------------- 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Director Operations, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.