From owner-svn-src-all@FreeBSD.ORG  Thu Feb 26 10:14:10 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5A06A1065670;
	Thu, 26 Feb 2009 10:14:10 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 497348FC08;
	Thu, 26 Feb 2009 10:14:10 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1QAEAQt024397;
	Thu, 26 Feb 2009 10:14:10 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1QAEAv9024396;
	Thu, 26 Feb 2009 10:14:10 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <200902261014.n1QAEAv9024396@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Thu, 26 Feb 2009 10:14:10 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r189060 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Feb 2009 10:14:10 -0000

Author: ed
Date: Thu Feb 26 10:14:10 2009
New Revision: 189060
URL: http://svn.freebsd.org/changeset/base/189060

Log:
  Don't use PTY name as format string, even though it isn't insecure here.
  
  It's guaranteed that the `name' variable always contains a string of the
  form pty[l‐sL‐S][0‐9a‐v], but I'd rather keep the compiler happy (LLVM).

Modified:
  head/sys/kern/tty_pty.c

Modified: head/sys/kern/tty_pty.c
==============================================================================
--- head/sys/kern/tty_pty.c	Thu Feb 26 06:16:15 2009	(r189059)
+++ head/sys/kern/tty_pty.c	Thu Feb 26 10:14:10 2009	(r189060)
@@ -113,7 +113,7 @@ pty_clone(void *arg, struct ucred *cr, c
 
 	/* Create the controller device node. */
 	*dev = make_dev_credf(MAKEDEV_REF, &ptydev_cdevsw, 0,
-	    NULL, UID_ROOT, GID_WHEEL, 0666, name);
+	    NULL, UID_ROOT, GID_WHEEL, 0666, "%s", name);
 }
 
 static void