From owner-cvs-all@FreeBSD.ORG  Thu Aug  7 07:18:15 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 84ECB37B40A; Thu,  7 Aug 2003 07:18:15 -0700 (PDT)
Received: from mail.tcoip.com.br (erato.tco.net.br [200.220.254.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 83DAA43FA3; Thu,  7 Aug 2003 07:18:10 -0700 (PDT)
	(envelope-from dcs@tcoip.com.br)
Received: from tcoip.com.br ([10.0.2.6])
	by mail.tcoip.com.br (8.11.6/8.11.6) with ESMTP id h77EI3j21219;
	Thu, 7 Aug 2003 11:18:03 -0300
Message-ID: <3F325F9A.8020906@tcoip.com.br>
Date: Thu, 07 Aug 2003 11:18:02 -0300
From: "Daniel C. Sobral" <dcs@tcoip.com.br>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20030702
X-Accept-Language: en-us, en, pt-br, ja
MIME-Version: 1.0
To: Nate Lawson <njl@FreeBSD.org>
References: <200308070446.h774kHAq037869@repoman.freebsd.org>
In-Reply-To: <200308070446.h774kHAq037869@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/contrib/dev/acpica acfreebsd.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2003 14:18:16 -0000

Nate Lawson wrote:
> njl         2003/08/06 21:46:17 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/contrib/dev/acpica acfreebsd.h 
>   Log:
>   Add includes to fix user-compilation of acpica.  Also clarify a comment
>   about overriding the OS name.

This commit broke world on loader.

The problem is sys/boot/i386/libi386/biosacpi.c, which includes this 
file since your rev 1.5 commit. :-)

Specifically, stand.h, which is included by anything that uses libstand 
functions (such as is the case with biosacpi.c), is mutually exclusive 
with ctype.h.

Specifically:

/* Not building kernel code, so use libc */

is false on both accounts for loader. :-) Loader is not kernel, alright, 
but neither does it use libc.

Since I'm not familiar with how, exactly, is acfreebsd.h used, I can't 
offer more advise. :-)

Tricky, eh? :-)

Shouldn't ctype.h be a required include to anything including acfreebsd.h?

-- 
Daniel C. Sobral                   (8-DCS)
Gerencia de Operacoes
Divisao de Comunicacao de Dados
Coordenacao de Seguranca
VIVO Centro Oeste Norte
Fones: 55-61-313-7654/Cel: 55-61-9618-0904
E-mail: Daniel.Capo@tco.net.br
         Daniel.Sobral@tcoip.com.br
         dcs@tcoip.com.br

Outros:
	dcs@newsguy.com
	dcs@freebsd.org
	capo@notorious.bsdconspiracy.net

Old mail has arrived.