From owner-freebsd-embedded@FreeBSD.ORG  Mon Apr 22 05:40:01 2013
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 76B5F4CA
 for <freebsd-embedded@smarthost.ysv.freebsd.org>;
 Mon, 22 Apr 2013 05:40:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 6954E113B
 for <freebsd-embedded@smarthost.ysv.freebsd.org>;
 Mon, 22 Apr 2013 05:40:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3M5e1eH023507
 for <freebsd-embedded@freefall.freebsd.org>; Mon, 22 Apr 2013 05:40:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3M5e172023506;
 Mon, 22 Apr 2013 05:40:01 GMT (envelope-from gnats)
Date: Mon, 22 Apr 2013 05:40:01 GMT
Message-Id: <201304220540.r3M5e172023506@freefall.freebsd.org>
To: freebsd-embedded@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: bin/177872: commit references a PR
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Apr 2013 05:40:01 -0000

The following reply was made to PR bin/177872; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/177872: commit references a PR
Date: Mon, 22 Apr 2013 05:30:27 +0000 (UTC)

 Author: adrian
 Date: Mon Apr 22 05:30:20 2013
 New Revision: 249748
 URL: http://svnweb.freebsd.org/changeset/base/249748
 
 Log:
   etherswitchcfg(8) crashes when you don't set vlangroup members.
   Fix this to require an argument.
   
   PR:		kern/177872
   Submitted by:	Luiz Otavio O Souza <loos.br@gmail.com>
 
 Modified:
   head/sbin/etherswitchcfg/etherswitchcfg.c
 
 Modified: head/sbin/etherswitchcfg/etherswitchcfg.c
 ==============================================================================
 --- head/sbin/etherswitchcfg/etherswitchcfg.c	Mon Apr 22 05:27:13 2013	(r249747)
 +++ head/sbin/etherswitchcfg/etherswitchcfg.c	Mon Apr 22 05:30:20 2013	(r249748)
 @@ -467,8 +467,11 @@ main(int argc, char *argv[])
  		case MODE_PORT:
  		case MODE_VLANGROUP:
  			for(i=0; cmds[i].name != NULL; i++) {
 -				if (cfg.mode == cmds[i].mode && strcmp(argv[0], cmds[i].name) == 0
 -					&& argc >= cmds[i].args) {
 +				if (cfg.mode == cmds[i].mode && strcmp(argv[0], cmds[i].name) == 0) {
 +					if (argc < (cmds[i].args + 1)) {
 +						printf("%s needs an argument\n", cmds[i].name);
 +						break;
 +					}
  					(cmds[i].f)(&cfg, argv);
  					argc -= cmds[i].args;
  					argv += cmds[i].args;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"