From nobody Thu Dec 11 09:02:10 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dRmmz0pbhz6Kc5P for ; Thu, 11 Dec 2025 09:02:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dRmmz00gkz3cMb for ; Thu, 11 Dec 2025 09:02:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765443731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GVFrvtZaBYQaSJQd0L8EFdXQ+DpuFKeuD0+pMIcADYU=; b=deEk+Uo/WXYhGJCzWqiFfhEw8hy6qZNDP0zRGKnxjGm5oBt1FWtbHcX/4RuQkddpftB/sQ LHtimT4AHNY5qNsno/Je/GbCsHFVNFiY1nsEy1dmT4DtiQoFyYOw+8tlXzQOygSwRSKWp4 rz5beUAj6Q0Me3xX9ILExDZ7hlDWXvYTgW/SxhRNhoKYjHcaNCKu41p0g6+NzvMLBYUYtY 1ocOkufSHU7kClZIQeFP7DPFmy1tMNrFdAAgzVyL+OKaOhRtY2UDZYW5naDKAnE2E+NvJm hkYlXWduuCF4kAbG2IAUCh/OCjRwb+vgLaEO4tGY61iR/MaOPRry8THBmll/iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765443731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GVFrvtZaBYQaSJQd0L8EFdXQ+DpuFKeuD0+pMIcADYU=; b=wA762Zwp4r/d476wXLADyqft47/Unr9q1B8JtlHpz4zObUDrH5pyaNrqns3DOMVg8NCu2F X+zpOVfNa2C8TGBeuGRqg6RdBwIbNp5d2Z/wsThNDN4fC7jTUScgRFFCXGKEaW4m9cIAdR 5//0t4cwvNTzn7q4Tzg3jTldYwTStyvo8Tgdgjb94bm9epXvSR559h3RORFTrW8N/OdoHR SePDyuHd/DLlnKUs+rvyYti8JJKBNKQc6dNkmWdp6yFcjBKci/QwRfXzjCRMdNf3sVVCKK szJCKsVNyczonsNLqQMb0yOoIwq7cutXGkUMwnTgMBftMFUmKUEDvbyqahXZ8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765443731; a=rsa-sha256; cv=none; b=wS9FtXwOUwYFZmreeDWuP51hzCfRj0iQHfejWFdtZriK8k21NawNcU8Fil1a8jamYT/xDT WUxyohITFX1YgxnVwEiWqzyPSp06aIyzjk/mvMyVPc1dbuZFRz7uNLTDR31a1Q8OEXKLc6 Bb7SDJoCJ8mb8mdBJU4iskHEdH6tvrZxkc0fs5c4lyjpfboFw8XOd+5Wlh1ua4abzdAasY 8yNJBgY/zZ7zfNx92EfnHVYSwnT0BcroGb1uB7IQviwZ/W2WaGSBZE8rHuD1s0xAKOY9uw XiVrffiOMVMr2128R9CoKKsGqt0+H6kiqa/kj+2HP4d71ROxYVnTPP34NEPJLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dRmmy6TVnz8nL for ; Thu, 11 Dec 2025 09:02:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31030 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 11 Dec 2025 09:02:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: a35545ee0268 - main - vm: Fix kstack alignment assertion List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a35545ee02680cee04c354b50182dd94d4489666 Auto-Submitted: auto-generated Date: Thu, 11 Dec 2025 09:02:10 +0000 Message-Id: <693a8892.31030.200d994c@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a35545ee02680cee04c354b50182dd94d4489666 commit a35545ee02680cee04c354b50182dd94d4489666 Author: Dag-Erling Smørgrav AuthorDate: 2025-12-11 09:01:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-12-11 09:02:07 +0000 vm: Fix kstack alignment assertion The expectation that the allocation will be aligned to the kstack size only applies when allocating from a kstack arena, not when allocating a non-standard size from the kernel arena. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Fixes: 7a79d0669761 ("vm: improve kstack_object pindex calculation to avoid pindex holes") Reviewed by: bnovkov, siderop1_netapp.com Differential Revision: https://reviews.freebsd.org/D54171 --- sys/vm/vm_glue.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sys/vm/vm_glue.c b/sys/vm/vm_glue.c index 18d789c59281..925bb92cdd75 100644 --- a/sys/vm/vm_glue.c +++ b/sys/vm/vm_glue.c @@ -321,10 +321,12 @@ vm_thread_alloc_kstack_kva(vm_size_t size, int domain) rv = vmem_alloc(arena, size, M_BESTFIT | M_NOWAIT, &addr); if (rv == ENOMEM) return (0); - KASSERT(atop(addr - VM_MIN_KERNEL_ADDRESS) % - (kstack_pages + KSTACK_GUARD_PAGES) == 0, - ("%s: allocated kstack KVA not aligned to multiple of kstack size", - __func__)); + if (size == ptoa(kstack_pages + KSTACK_GUARD_PAGES)) { + /* This expectation only applies to kstack arenas */ + KASSERT((addr - VM_MIN_KERNEL_ADDRESS) % size == 0, + ("%s: allocated kstack KVA not aligned to multiple of kstack size", + __func__)); + } return (addr); #else