From owner-svn-src-all@freebsd.org  Thu Nov  8 16:25:31 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F89D112F8A7;
 Thu,  8 Nov 2018 16:25:31 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 772B485F50;
 Thu,  8 Nov 2018 16:25:30 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [178.17.145.230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 164BE2601FE;
 Thu,  8 Nov 2018 17:25:23 +0100 (CET)
Subject: Re: svn commit: r340246 - head/usr.sbin/newsyslog
To: Mark Johnston <markj@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201811081243.wA8ChEsP009030@repo.freebsd.org>
 <20181108161429.GA24751@raichu>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <19afa685-8109-566c-6a8a-91b712e80fe9@selasky.org>
Date: Thu, 8 Nov 2018 17:24:49 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.0.1
MIME-Version: 1.0
In-Reply-To: <20181108161429.GA24751@raichu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 772B485F50
X-Spamd-Result: default: False [-4.86 / 200.00]; ARC_NA(0.00)[];
 RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4];
 R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net];
 TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain];
 DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0];
 TO_DN_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail.turbocat.net];
 NEURAL_HAM_SHORT(-0.99)[-0.988,0]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[];
 IP_SCORE(-1.57)[ipnet: 88.99.0.0/16(-4.91), asn: 24940(-2.91), country:
 DE(-0.01)]; 
 ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE];
 MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[];
 RCVD_COUNT_TWO(0.00)[2]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2018 16:25:31 -0000

On 11/8/18 5:14 PM, Mark Johnston wrote:
> On Thu, Nov 08, 2018 at 12:43:14PM +0000, Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Thu Nov  8 12:43:13 2018
>> New Revision: 340246
>> URL: https://svnweb.freebsd.org/changeset/base/340246
>>
>> Log:
>>    Add /var/log/opensm.log to list of rotating log files.
>>    
>>    MFC after:		3 days
>>    Sponsored by:		Mellanox Technologies
>>
>> Modified:
>>    head/usr.sbin/newsyslog/newsyslog.conf
> 
> There is already an usr.sbin/newsyslog/newsyslog.d/opensm.conf.
> 
Thank you. Do you have any objections adding a size limit for 
opensm.conf, and also to use bzip2?

> Index: usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf
> ===================================================================
> --- usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf	(revision 339922)
> +++ usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf	(working copy)
> @@ -1,3 +1,3 @@
>  # $FreeBSD$
>  
> -/var/log/opensm.log			600  7	*	*	Z	/var/run/opensm.pid	30
> +/var/log/opensm.log			600  7	1000	*	J	/var/run/opensm.pid	30

--HPS

>>
>> Modified: head/usr.sbin/newsyslog/newsyslog.conf
>> ==============================================================================
>> --- head/usr.sbin/newsyslog/newsyslog.conf	Thu Nov  8 09:45:13 2018	(r340245)
>> +++ head/usr.sbin/newsyslog/newsyslog.conf	Thu Nov  8 12:43:13 2018	(r340246)
>> @@ -26,6 +26,7 @@
>>   /var/log/maillog			640  7	   *	@T00  JC
>>   /var/log/messages			644  5	   1000	@0101T JC
>>   /var/log/monthly.log			640  12	   *	$M1D0 JN
>> +/var/log/opensm.log			644  3     1000 *     J
>>   /var/log/devd.log			644  3	   1000	*     JC
>>   /var/log/security			600  10	   1000	*     JC
>>   /var/log/utx.log			644  3	   *	@01T05 B
>>
> 
>