From owner-svn-src-head@freebsd.org Sun Nov 22 15:53:51 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F078C46C597; Sun, 22 Nov 2020 15:53:51 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CfFFW6GpFz3PkR; Sun, 22 Nov 2020 15:53:51 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: by mail-wm1-x332.google.com with SMTP id c9so15568339wml.5; Sun, 22 Nov 2020 07:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=JF+dcUSrNzWxGW/+RjCz2YghkSyoLJx9qtHZauTB5rw=; b=XY9EBWN81IyG6bXiJQKbglETBSDsFL8edWKJmy1xwAUE5FPvpI2L/E07Y+lctxIBIW 8yWvfVHjWyO07iVwgNMgd/ejVJjsYkxYZENzCpWCR5zx9A8YoV6H3E5Smtl2QN5CHvr+ 9Px1jsDjsxrRFxftz026J8EsINV7hPPoaMZPN9k2OFpn2/22CBhhRpQbb/L4qWjFciUn SEeifaPaOhS0WH4Ig5H61Py9Bbc0BvZuOleauP8Hwm8Bv+bIhEmRLpDiWUjFlmlANBCu DX8lvFZZm+4jJZfJd/AUR56BILjgcY+eJn7YyS9/XHSvNMy78h3hmXaoDdQMNWR0Po7e TDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=JF+dcUSrNzWxGW/+RjCz2YghkSyoLJx9qtHZauTB5rw=; b=JsKIJUD3vwnO+j327xPCWW6dOnXrBrCZMUOQOkXK9J75yUeazzy+I4MlhhZjwo3GHh EjYw0QwdLfyAk65Tk1ifKsTJ/c1kP7b2HfB/gM46DxTm98z/YMXekDxE/OSMe8XdfpWZ JfqCIknchV3VOEHqwWx6E8YZiOwtHvaeFm0ZOgWOS3N6ZPqZrzbE3iW4115xS4gmTQvG 6R8G4BGqfnwsiVtKlJm9XnM8bElWBXvKD+S4L2TR7ZfmOzpeyyeKIib4SxXH4gzG15Jc KEvRNoOWp5TLOYKLixj+QWESjFdKKOlagFhVz5QS++ISLOM2mZS7TR5WF133MwFjRJvm iUbg== X-Gm-Message-State: AOAM532Wc47WI+SRMcmaCQckenrgGMsbGz7fdT2lfHYdBguK62XFL+2w dHsFJjbgnem9XRSsLL2yDsDiRBi3n0bdTz3c X-Google-Smtp-Source: ABdhPJwMTGU1oOL6J93Q3WQDH0lwSgArxSP1y0qUulNcFZZITM26D9aSM9qV/OPLxDZlNHaNz4LlyQ== X-Received: by 2002:a1c:5f83:: with SMTP id t125mr19322022wmb.82.1606060429725; Sun, 22 Nov 2020 07:53:49 -0800 (PST) Received: from ?IPv6:2a02:ed0:33ff:5501:33e8:8c9b:8d89:594d? ([2a02:ed0:33ff:5501:33e8:8c9b:8d89:594d]) by smtp.gmail.com with ESMTPSA id z17sm2963429wmf.15.2020.11.22.07.53.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 07:53:49 -0800 (PST) Subject: Re: svn commit: r367927 - in head: sys/kern tests/sys/kern To: Robert Wing References: <202011220500.0AM50Tml047660@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Guy Yur Message-ID: <75a09790-79d8-f539-e118-acf32b6bc65e@gmail.com> Date: Sun, 22 Nov 2020 17:53:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <202011220500.0AM50Tml047660@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CfFFW6GpFz3PkR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2020 15:53:52 -0000 On 22/11/20 7:00 am, Robert Wing wrote: > Author: rew > Date: Sun Nov 22 05:00:28 2020 > New Revision: 367927 > URL: https://svnweb.freebsd.org/changeset/base/367927 > > Log: > fd: free old file descriptor tables when not shared > > During the life of a process, new file descriptor tables may be allocated. When > a new table is allocated, the old table is placed in a free list and held onto > until all processes referencing them exit. > > When a new file descriptor table is allocated, the old file descriptor table > can be freed when the current process has a single-thread and the file > descriptor table is not being shared with any other processes. > > Reviewed by: kevans > Approved by: kevans (mentor) > Differential Revision: https://reviews.freebsd.org/D18617 > > Added: > head/tests/sys/kern/fdgrowtable_test.c (contents, props changed) > Modified: > head/sys/kern/kern_descrip.c > head/tests/sys/kern/Makefile Hi, I am getting a kernel panic with this commit when building devel/gmake port and it runs dup2 test in configure script. panic: fc_ioctls != NULL, but fc_nioctls=-16162 ... #10 0xffffffff80655c72 in vpanic (fmt=, ap=)     at /usr/src/sys/kern/kern_shutdown.c:907 #11 0xffffffff80655a03 in panic (     fmt=0xffffffff80eb2b78 "헝\200\377\377\377\377")     at /usr/src/sys/kern/kern_shutdown.c:843 #12 0xffffffff805fff9a in filecaps_copy_prep (src=)     at /usr/src/sys/kern/kern_descrip.c:1629 #13 kern_dup (td=, mode=, flags=0,     old=, new=256) at /usr/src/sys/kern/kern_descrip.c:970 #14 0xffffffff8094a5de in syscallenter (td=)     at /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:189 #15 amd64_syscall (td=0xfffffe00513f8500, traced=0)     at /usr/src/sys/amd64/amd64/trap.c:1156 Simplified test program that causes panic: #include #include int main () {   int bad_fd = INT_MAX;   dup2 (1, 1);   close (0);   dup2 (0, 0);   dup2 (2, bad_fd);   dup2 (2, -1);   dup2 (2, 255);   dup2 (2, 256);   return 0; } Thanks, Guy Yur