From owner-freebsd-dtrace@FreeBSD.ORG Wed Apr 16 01:09:04 2014 Return-Path: Delivered-To: freebsd-dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 156D57B6 for ; Wed, 16 Apr 2014 01:09:04 +0000 (UTC) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D987B14A8 for ; Wed, 16 Apr 2014 01:09:03 +0000 (UTC) Received: by mail-ig0-f181.google.com with SMTP id h18so477287igc.8 for ; Tue, 15 Apr 2014 18:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Htbtq5Qv/fJFnMgdgiaLpTzho9jPRwDIVx7OvLQIe3c=; b=uDPBaE9mLWsUi0NKY/3AwyCgcZq1+sUVfPtcWnDL2dciEQBWZMXQB+8fHnshMPJhGo AdBhGl6j8gVdcdQxHN0ldysrKJ1WaA8iEwlxTKuAdO/dV6BuRmBVQd3pBuvVT7ob43jB +CGJmeU3icAfV6TFyt6SgWO5vCR3Vou/+GcdSb50gw77nohPIcPFDEQJ+UdOXjooaBgQ 7j6Hkr3vsmuMbIAgGDi5wL87EwW0NHGBM6wsS8JRkqDIpu3SLvv/QX8CkSfSGHwAj2h5 kijAXktafwLZNz/OYDK4iBDb6HbZjd+F3iOi4yumiT5utxWvaR2iBDHpkUW9dGPYAVSb fWpg== MIME-Version: 1.0 X-Received: by 10.50.30.170 with SMTP id t10mr1545432igh.7.1397610543352; Tue, 15 Apr 2014 18:09:03 -0700 (PDT) Sender: markjdb@gmail.com Received: by 10.64.19.241 with HTTP; Tue, 15 Apr 2014 18:09:03 -0700 (PDT) In-Reply-To: References: Date: Tue, 15 Apr 2014 21:09:03 -0400 X-Google-Sender-Auth: LtXWADW-H5eB4SR4IqWw3w_j-xM Message-ID: Subject: Re: uaddr and friends From: Mark Johnston To: carlos antonio neira bustos Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-dtrace@freebsd.org" X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 01:09:04 -0000 On Tue, Apr 15, 2014 at 8:35 PM, carlos antonio neira bustos wrote: > Hi All, > > I was looking at Dtrace todo list from https://wiki.freebsd.org/DTraceTODO > and started to work on : Get uaddr(), ufunc(), umod(), and usym() action > funtions working. > I have the data recording action (uaddr) working now, here is an > example: Hi! Hm, these should have been (at least mostly) working since r258902: http://svnweb.freebsd.org/base?view=revision&revision=258902 > > root@bsd:/home/cneira # dtrace -n 'pid$target::main:{uaddr(uregs[R_PC])}' > -c ./test > dtrace: description 'pid$target::main:' matched 2 probes > abCPU ID FUNCTION:NAME > 0 56282 main:entry > test`main+0x1 > > 0 56281 main:return > test`main+0x23 > > dtrace: pid 9687 has exited > > Here is the output of nm from the test binary I have used to check this > change. > > U _init_tls@@FBSD_1.0 > 08048380 T _start > 080483a0 t _start1 > 0804814c r abitag > U atexit@@FBSD_1.0 > 08048164 r crt_noinit_tag > 080485c0 T dosomething > 08049764 B environ > U exit@@FBSD_1.0 > 080484f0 t finalizer > 08048560 t frame_dummy > 08048590 T main > U putchar@@FBSD_1.0 > > > root@bsd:/home/cneira # dtrace -c ./test -n 'pid$target::main:entry{ > uaddr(0x080485c0); }' > dtrace: description 'pid$target::main:entry' matched 1 probe > abCPU ID FUNCTION:NAME > 0 56281 main:entry > test`dosomething > > dtrace: pid 9736 has exited > > I'll continue working on the rest, how do I submit a patch with these > changes ? Pasting it inline is generally fine if it's not too large. It's also ok to put it in a public directory somewhere and post a link to it. -Mark