Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Mar 2009 21:47:49 GMT
From:      Michael Scheidell <scheidell@secnap.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/132760: [MAINTAINER UPDATE] minor fixes to p5-Mail-SpamAssassin for DKIM
Message-ID:  <200903172147.n2HLlnw2019654@www.freebsd.org>
Resent-Message-ID: <200903172150.n2HLo2Ue073617@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         132760
>Category:       ports
>Synopsis:       [MAINTAINER UPDATE] minor fixes to p5-Mail-SpamAssassin for DKIM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 17 21:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Michael Scheidell
>Release:        6.4
>Organization:
SECNAP Network Security
>Environment:
all
>Description:
DKIM continues to be updates to fix minor incompatibilities with vendor implementations.  DKIM .33 fixes a couple minor issues.

(see PR http://www.freebsd.org/cgi/query-pr.cgi?pr=132514 )

While not normally requiring a portrevision, the next fix will.

Bayes.pm was trying to cache/store/compare 'tokens' in the headers, and these tokens included dkim signatures.  However, as far as bayes would be concerned, these dkim signatures are 'random', as in never repeatable.  you would never have the same dkim signature token in any email.

this patch (recommended by spamassassin, see 
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5861 

addresses this.

Clients who are aggressively doing portsupgrade would get the .33 dkim anyway, but need the bump version to get the Bayes.pm patch


>How-To-Repeat:
get a email with a dkim or domainkey signature, see useless daya in bayes.

>Fix:
note, this includes the creation of files/patch-bayes.pm

(mind the wrap on Makefile , just bumped portrevision and set dkim minimum to .33)

diff -bBru ./ /var/tmp/SA/
diff -bBru ./Makefile /var/tmp/SA/Makefile
--- ./Makefile  2009-03-17 17:31:25.000000000 -0400
+++ /var/tmp/SA/Makefile        2009-01-14 10:40:16.000000000 -0500
@@ -7,7 +7,7 @@
 
 PORTNAME=      Mail-SpamAssassin
 PORTVERSION=   3.2.5
-PORTREVISION=  2
+PORTREVISION=  1
 CATEGORIES=    mail perl5
 MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/} ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
 MASTER_SITE_SUBDIR=    spamassassin/source/:apache Mail/:cpan
@@ -98,7 +98,7 @@
 .endif
 
 .if defined(WITH_DKIM)
-RUN_DEPENDS+=  p5-Mail-DKIM>=0.33:${PORTSDIR}/mail/p5-Mail-DKIM
+RUN_DEPENDS+=  p5-Mail-DKIM>=0.31:${PORTSDIR}/mail/p5-Mail-DKIM
 RUN_DEPENDS+=  ${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
 RUN_DEPENDS+=  p5-Crypt-OpenSSL-RSA>=0.24:${PORTSDIR}/security/p5-Crypt-OpenSSL-RSA
 .endif
diff -bBru ./files/patch-bayes.pm /var/tmp/SA/files/patch-bayes.pm
--- ./files/patch-bayes.pm      2009-03-17 17:28:23.000000000 -0400
+++ /var/tmp/SA/files/patch-bayes.pm    2009-03-17 17:28:23.000000000 -0400
@@ -1,10 +0,0 @@
---- Bayes.pm.orig      2008-06-10 05:20:22.000000000 -0400
-+++ lib/Mail/SpamAssassin/Bayes.pm     2008-08-22 03:23:38.000000000 -0400
-@@ -145,6 +145,7 @@
- # hapaxen they generate.
- $MARK_PRESENCE_ONLY_HDRS = qr{(?: X-Face
-   |X-(?:Gnu-?PG|PGP|GPG)(?:-Key)?-Fingerprint
-+  |D(?:KIM|omainKey)-Signature
- )}ix;
- 
- # tweaks tested as of Nov 18 2002 by jm: see SpamAssassin-devel list archives


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903172147.n2HLlnw2019654>