From owner-svn-src-head@freebsd.org Mon Jun 12 05:45:24 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADC8DBF483A; Mon, 12 Jun 2017 05:45:24 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ot0-x234.google.com (mail-ot0-x234.google.com [IPv6:2607:f8b0:4003:c0f::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DA17830A0; Mon, 12 Jun 2017 05:45:24 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-ot0-x234.google.com with SMTP id t31so61268368ota.1; Sun, 11 Jun 2017 22:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Ag8FI/4IkOjA/lRKuqSanSRqXGgOvuPSSlG54I6jMNg=; b=eE/DTyRLcmLghvFpPWg3sXG7N1zD+wYzvrgej72IoWobUXV/OuWYYRZAw1UzI2AiUu plpNhvJqGagMGZvOmNUsDzocZb/jvRcmvhzgDXLIIw45A66LsHgfp2NoVjbrey7I9esx clNJjgbfvAyyR2IBnbkjQA0uTAB0f2exggIFhUKWx9PkLZcoNY6er4hfQAjY57HeNI+p I15QFtTAuD/exDgv1emxBzoDX0iAclbff5GoHk1TqCY2alMA2XxgHlo4EO5gtrPQp1bT Zz02+rb8eV6B6hvR/tABGtDai/9xo76ElfHqYN3x/L/lHZr60tD5jJSWg2iBovO8k6h2 75DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=Ag8FI/4IkOjA/lRKuqSanSRqXGgOvuPSSlG54I6jMNg=; b=ICZMynor0NI4mBE7ryxgjvR4ymBkQEILEOdlexpa9BkDd53bn54gvnRVMP+XwLP/BL +47u2yYoarG75LkwOcbLQjYnhRvDaJzddfF7/e/mamnyI5nMxRe6xGtHqmkcOEB/GkdW JjofJ/9iAD1q6WtKFy8zEZ/CHkEdnNmZqYSMTSsS/BsPG5WA8d1nNp1+BubQ0WMc9pjy 8hScNPY+alllbnT9auPP6V+uzXkGHA8ndmvabYWIB/sOiQhcv6RxFfgk/1Rzgge8lFKt 2znTvM3FwX7h2ZlWwL7yoNtJfrhNj9J3u5FgHQIuN7V/IydF8wZ9a9MPqayQa3eTMrEQ axww== X-Gm-Message-State: AKS2vOwDzhQaYXPMGjhBJsKgKvSwXKFQVK/La5aqej9k1T4Tff4NHa/E eqxUL2rOgVKp7ike1XZXueNmJLjY6Q== X-Received: by 10.157.20.166 with SMTP id d35mr20650410ote.260.1497246323638; Sun, 11 Jun 2017 22:45:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.48.71 with HTTP; Sun, 11 Jun 2017 22:45:23 -0700 (PDT) Reply-To: araujo@freebsd.org In-Reply-To: References: <201706020235.v522ZGeC076100@repo.freebsd.org> From: Marcelo Araujo Date: Mon, 12 Jun 2017 13:45:23 +0800 Message-ID: Subject: Re: svn commit: r319487 - head/usr.sbin/bhyve To: "Conrad E. Meyer" Cc: Peter Grehan , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 05:45:24 -0000 2017-06-11 2:35 GMT+08:00 Conrad Meyer : > On Sat, Jun 10, 2017 at 11:14 AM, Peter Grehan wrote= : > > strncpy() is specified to zero-fill if the source is shorter than the > > length. Are we missing something ? > > > > The other issues you brought up look valid. > > Hi Peter, > > Oops =E2=80=94 didn't realize that about strncpy()! Thanks for the corre= ction. > > Best, > Conrad > Thanks guys, I will take a look on it very soon and will put you both into the review. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)