From owner-svn-src-head@freebsd.org Wed May 11 21:38:53 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B3CFB3758E; Wed, 11 May 2016 21:38:53 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F3E531F4B; Wed, 11 May 2016 21:38:52 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 0C28725D3860; Wed, 11 May 2016 21:38:48 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 1B4A4D1F84C; Wed, 11 May 2016 21:38:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 2HuRJamve-r2; Wed, 11 May 2016 21:38:46 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:adc4:89b5:7841:1aa4] (unknown [IPv6:fde9:577b:c1a9:4410:adc4:89b5:7841:1aa4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 148F2D1F839; Wed, 11 May 2016 21:38:45 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci From: "Bjoern A. Zeeb" In-Reply-To: <201605111707.u4BH7UXs040026@repo.freebsd.org> Date: Wed, 11 May 2016 21:38:26 +0000 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201605111707.u4BH7UXs040026@repo.freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 21:38:53 -0000 > On 11 May 2016, at 17:07 , Andrew Turner wrote: >=20 > Author: andrew > Date: Wed May 11 17:07:29 2016 > New Revision: 299467 > URL: https://svnweb.freebsd.org/changeset/base/299467 >=20 > Log: > Add a new get_id interface to pci and pcib. This will allow us to = both > detect failures, and get different PCI IDs. >=20 > For the former the interface returns an int to signal an error. The = ID is > returned at a uintptr_t * argument. >=20 > For the latter there is a type argument that allows selecting the ID = type. > This only specifies a single type, however a MSI type will be added > to handle the need to find the ID the hardware passes to the ARM = GICv3 > interrupt controller. >=20 > A follow up commit will be made to remove pci_get_rid. >=20 > Reviewed by: jhb, rstone > Obtained from: ABT Systems Ltd > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D6239 Hi, seems gcc, I guess it is, doesn=E2=80=99t like your change: In file included from = /scratch/tmp/bz/head.svn/sys/sparc64/isa/ofw_isa.c:78: ./pcib_if.h:166: warning: 'enum pci_id_type' declared inside parameter = list ./pcib_if.h:166: warning: its scope is only this definition or = declaration, which is probably not what you want ./pcib_if.h:169: warning: 'enum pci_id_type' declared inside parameter = list ./pcib_if.h:169: error: parameter 3 ('type') has incomplete type ./pcib_if.h: In function 'PCIB_GET_ID': ./pcib_if.h:173: error: type of formal parameter 3 is incomplete