From owner-dev-commits-src-main@freebsd.org  Mon Jan 11 19:05:43 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 875BE4E32A8;
 Mon, 11 Jan 2021 19:05:43 +0000 (UTC)
 (envelope-from rlibby@gmail.com)
Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com
 [209.85.160.174])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DF37q3F51z4hwV;
 Mon, 11 Jan 2021 19:05:43 +0000 (UTC)
 (envelope-from rlibby@gmail.com)
Received: by mail-qt1-f174.google.com with SMTP id r9so34307qtp.11;
 Mon, 11 Jan 2021 11:05:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ySKTo6F2wXxoE9wNYXo5eEpB9UG2QlAAFQzmbBCQpO8=;
 b=XX5U6itNAjeZmBh9PsibOkNRhdo8NsRNlsrPR6F//XiwSEr7MKaHUlRldMJnNjvaSp
 3oLYEHOIjb1xd6b4pfh31jKBxuxTImqoWxKdkGEm/mTUdJWrhcq3TPXkisZutbSJgp36
 qrXFON5L5EgmTfuEuM/vnbXC+Rgvq0M145QDpexfRhsX8wfgweQsixucebrrNwX5DAvm
 UE7qZ4ksDxaPWIi4nVC+E8CTKWXOuU+FYO58jukyIeJ2OUKgWS62kthpmJmpgcX+bFio
 He2p/OVkCtj2YEvfsanQac382oeOhT9VEXwZV1NaCkSWWoxz8/jGA9ypTWSxdlo1B5S/
 PSqg==
X-Gm-Message-State: AOAM533gSXWrj4IwgeJqjE4HWGNPx4Mp6ahb5fCaYvqauzSCTjVRBUtO
 Xbrb7KVZH4PzTRViNLah1QyvBeqPGv7anQ==
X-Google-Smtp-Source: ABdhPJxDLylM9j+sfSXBwFVpGof+SDUVAedDXX8c7vip4XhNlG41J1S8jomtz8yr3Hsv4XI/9abZsg==
X-Received: by 2002:ac8:4b54:: with SMTP id e20mr1075130qts.236.1610391941842; 
 Mon, 11 Jan 2021 11:05:41 -0800 (PST)
Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com.
 [209.85.222.180])
 by smtp.gmail.com with ESMTPSA id f6sm419807qkh.2.2021.01.11.11.05.41
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 11 Jan 2021 11:05:41 -0800 (PST)
Received: by mail-qk1-f180.google.com with SMTP id w79so508296qkb.5;
 Mon, 11 Jan 2021 11:05:41 -0800 (PST)
X-Received: by 2002:a37:6189:: with SMTP id v131mr721739qkb.337.1610391940354; 
 Mon, 11 Jan 2021 11:05:40 -0800 (PST)
MIME-Version: 1.0
References: <202101110554.10B5sW2q070743@gitrepo.freebsd.org>
 <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org>
In-Reply-To: <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org>
From: Ryan Libby <rlibby@freebsd.org>
Date: Mon, 11 Jan 2021 11:05:29 -0800
X-Gmail-Original-Message-ID: <CAHgpiFxxWvskdf9PyDkB4mhf6c=+BKGnhVMH1iTLB6su_tzqXg@mail.gmail.com>
Message-ID: <CAHgpiFxxWvskdf9PyDkB4mhf6c=+BKGnhVMH1iTLB6su_tzqXg@mail.gmail.com>
Subject: Re: git: 16079c7233be - main - hid: quiet -Wswitch
To: Hans Petter Selasky <hselasky@freebsd.org>,
 Vladimir Kondratyev <wulf@freebsd.org>, John Baldwin <jhb@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 4DF37q3F51z4hwV
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2021 19:05:43 -0000

On Mon, Jan 11, 2021 at 10:04 AM John Baldwin <jhb@freebsd.org> wrote:
>
> On 1/10/21 9:54 PM, Ryan Libby wrote:
> > The branch main has been updated by rlibby:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370
> >
> > commit 16079c7233be8bd6c88e3421a70c7ca87cfea370
> > Author:     Ryan Libby <rlibby@FreeBSD.org>
> > AuthorDate: 2021-01-11 05:53:15 +0000
> > Commit:     Ryan Libby <rlibby@FreeBSD.org>
> > CommitDate: 2021-01-11 05:53:15 +0000
> >
> >     hid: quiet -Wswitch
> >
> >     Gcc builds complained that not all switch cases are handled.  Add
> >     default cases to appease gcc.
> >
> >     Reviewed by:    hselasky (previous version), wulf
> >     Sponsored by:   Dell EMC Isilon
> >     Differential Revision:  https://reviews.freebsd.org/D28082
>
> If these cases are never reachable, then I think '__assert_unreachable()'
> is preferred to a plain break.
>
> --
> John Baldwin

I'll have to let wulf and hselasky speak to that...