From owner-cvs-all@FreeBSD.ORG Wed Mar 9 21:10:38 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4880E16A4FA; Wed, 9 Mar 2005 21:10:38 +0000 (GMT) Received: from pd3mo2so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A024D43D2D; Wed, 9 Mar 2005 21:10:37 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd5mr5so.prod.shaw.ca (pd5mr5so-qfe3.prod.shaw.ca [10.0.141.181]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0ID300K8WS5PEDB0@l-daemon>; Wed, 09 Mar 2005 14:10:37 -0700 (MST) Received: from pn2ml5so.prod.shaw.ca ([10.0.121.149]) by pd5mr5so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0ID300FFDS5P4WF0@pd5mr5so.prod.shaw.ca>; Wed, 09 Mar 2005 14:10:37 -0700 (MST) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0ID300DL7S5OFO@l-daemon>; Wed, 09 Mar 2005 14:10:37 -0700 (MST) Date: Wed, 09 Mar 2005 13:10:35 -0800 From: Colin Percival In-reply-to: <20050309210113.GQ9291@darkness.comp.waw.pl> To: Pawel Jakub Dawidek Message-id: <422F664B.2080001@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.90.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime References: <200503091923.j29JN4Ti063868@repoman.freebsd.org> <422F50A6.907@criticalmagic.com> <422F55C6.3000207@freebsd.org> <422F5B36.5090400@criticalmagic.com> <422F5D94.4030702@freebsd.org> <20050309210113.GQ9291@darkness.comp.waw.pl> User-Agent: Mozilla Thunderbird 1.0 (X11/20050302) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Richard Coleman cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c shadriver.c src/sbin/md5 Makefile md5.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2005 21:10:38 -0000 Pawel Jakub Dawidek wrote: > On Wed, Mar 09, 2005 at 12:33:24PM -0800, Colin Percival wrote: > +> My personal feeling is that sha(384|512) are overkill on the side of > +> hash length and probably underkill on the side of design (considering > +> that they have the same basic design which has been repeatedly shown > +> to be vulnerable to the Chinese attack) anyway -- we really need an > +> AES-like process for selecting a new hash standard. > > Colin, with all due respect. I don't think your personal feeling should be > the reason to not support sha(384|512). Of course -- I was just mentioning it as a side note. > If you think your version is cleaner/better that the one from sys/, maybe > it should be reviewed and sys/ version replaced, but we should not duplicate > crypto code. Again, I didn't know there was a version in sys/ until Richard pointed it out; if someone wants to rip my sha256c.c out and replace it with some sort of build magic which sucks in the version from sys/, I have no objection. Colin Percival