From owner-cvs-all Sat Dec 21 16:28:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7B6037B401; Sat, 21 Dec 2002 16:28:33 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75EF343EDA; Sat, 21 Dec 2002 16:28:32 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id LAA26828; Sun, 22 Dec 2002 11:28:19 +1100 Date: Sun, 22 Dec 2002 11:30:06 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Sam Leffler Cc: Nate Lawson , , Subject: Re: cvs commit: src/sys/sys time.h src/sys/kern kern_time.c In-Reply-To: <129901c2a927$7767df70$52557f42@errno.com> Message-ID: <20021222110710.Y7634-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 21 Dec 2002, Sam Leffler wrote: > The version in sys/time.h is #ifndef _KERNEL and marked as specifically for > compatibility for netbsd. Rather than change the include file and pollute a > namespace I added a private definition. If it's ok to do add this pollution > then sure, just remove the private definition. Not OK. Use the 4.xBSD timeval*() interfaces for manipulating timevals, not the NetBSD timer*() ones. Better still, don't use timevals for new interfaces; use timespecs and timespec*(). Rate limiting doesn't need either nsec or usec resolution so it may as well use a non-legacy type for times. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message