From owner-freebsd-arch@FreeBSD.ORG Tue May 27 19:48:43 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3A67106564A for ; Tue, 27 May 2008 19:48:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 089818FC12 for ; Tue, 27 May 2008 19:48:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m4RJmNQL036386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 May 2008 22:48:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m4RJmNLl029864; Tue, 27 May 2008 22:48:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m4RJmNhK029863; Tue, 27 May 2008 22:48:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 27 May 2008 22:48:23 +0300 From: Kostik Belousov To: Ed Schouten Message-ID: <20080527194823.GT21317@deviant.kiev.zoral.com.ua> References: <20080527130615.GJ64397@hoeg.nl> <20080527150244.GN21317@deviant.kiev.zoral.com.ua> <20080527165753.GK64397@hoeg.nl> <20080527191302.GS21317@deviant.kiev.zoral.com.ua> <20080527193242.GN64397@hoeg.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OowMmFE4aK71mEhh" Content-Disposition: inline In-Reply-To: <20080527193242.GN64397@hoeg.nl> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua Cc: arch@freebsd.org Subject: Re: Simplifying devfs: minor == unit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2008 19:48:43 -0000 --OowMmFE4aK71mEhh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 27, 2008 at 09:32:42PM +0200, Ed Schouten wrote: > * Kostik Belousov wrote: > > On Tue, May 27, 2008 at 06:57:53PM +0200, Ed Schouten wrote: > > >=20 > > > Please take a look at src/usr.sbin/watch/watch.c:open_snp(). We might= as > > > well turn snp(4) into a single /dev/snp, where the kernel space driver > > > uses per-descriptor data to distinguish the instances. This provides > > > some advantages: > > >=20 > > > - No more silly open()-loops. > > >=20 > > > - A system administrator can change the permissions on /dev/snp, which > > > automatically sets a system wide policy, instead on one of the devi= ce > > > nodes. > > >=20 > > > - We don't fill up the system with a lot of unused nodes. > > >=20 > > > for i in `seq 1000` > > > do > > > ls /dev/bpf$i > /dev/null > > > done > > Please, do not overuse the cdevpriv data (I am not speaking about snp/w= atch > > ATM, each case requires careful decision). Using cdevpriv disables some > > features that may be provided by the clones, i.e. actual cdevs. For exa= mple, > > you cannot have several independent opens operate on the same instance. >=20 > I'll take a closer look at how it works when time permits. >=20 > Do you mind if I commit the minor =3D=3D unit patch one of these days/wee= ks? >=20 In fact, I do not understand why you leave the UMINORMASK stuff. It makes no sense with the unit =3D=3D minor, IMHO. --OowMmFE4aK71mEhh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkg8ZYYACgkQC3+MBN1Mb4hL3wCg9+DhkoQYsMdsaPCrjrfmhtXk UNsAmwXuUbbwwGhwSBQ4yuedU47x7gjG =K+HF -----END PGP SIGNATURE----- --OowMmFE4aK71mEhh--