Date: Sat, 24 Jun 2000 15:52:02 -0300 From: "Mario Sergio Fujikawa Ferreira" <lioux@uol.com.br> To: Neil Blakey-Milner <nbm@mithrandr.moria.org> Cc: Mario Sergio Fujikawa Ferreira <lioux@uol.com.br>, freebsd-ports@FreeBSD.org Subject: Re: ports/19449: The qmail port has /usr/local hardwired into it, and doesn't cerate /etc/mail/mailer.conf Message-ID: <20000624155202.A22523@Fedaykin.here> In-Reply-To: <20000623103926.B18169@mithrandr.moria.org>; from nbm@mithrandr.moria.org on Fri, Jun 23, 2000 at 10:39:26AM %2B0200 References: <200006230710.AAA72372@freefall.freebsd.org> <20000623103926.B18169@mithrandr.moria.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 23, 2000 at 10:39:26AM +0200, Neil Blakey-Milner wrote:
> On Fri 2000-06-23 (00:10), Mario Sergio Fujikawa Ferreira wrote:
> > +thereal-disable-sendmail: ${WRKDIR}/.thereal_disable_sendmail_done /etc/rc.conf
> > + @if [ -f /etc/rc.conf ]; \
> > + then \
> > + ${CP} /etc/rc.conf /etc/rc.conf.bak && \
> > + ${GREP} -v sendmail_enable /etc/rc.conf.bak > \
> > + /etc/rc.conf && \
> > + ${TOUCH} ${WRKDIR}/.thereal_disable_sendmail_done ; \
>
> Why this? If you have this:
>
> > +
> > +disable-sendmail: thereal-disable-sendmail
> > + @if [ -f /etc/rc.conf ]; \
> > + then \
> > + ${ECHO} sendmail_enable=\"NO\" >> /etc/rc.conf ; \
> > + fi
Because, I don't want to have 15 sendmail_enable="NO" if
I can have only one. :)
Besides I can share the sendmail_enable code across targets.
> > +# taken from mail/postfix idea
> > +force-enable-qmail: install disable-sendmail
> > + @${ECHO_MSG} "===> Replacing sendmail"
> > + @if [ -e /usr/sbin/sendmail ]; then \
> > + ${MV} -f /usr/sbin/sendmail /usr/sbin/sendmail.OFF && \
> > + ${CHMOD} 0 /usr/sbin/sendmail.OFF; \
> > + fi
> > + @if [ -e ${PREFIX}/bin/sendmail ]; then \
> > + ${LN} -s ${PREFIX}/bin/sendmail /usr/sbin/sendmail; \
> > + fi
> > + @${ECHO_MSG} "===> Replacing mailq"
> > + @if [ -e /usr/bin/mailq ]; then \
> > + ${MV} -f /usr/bin/mailq /usr/bin/mailq.OFF && \
> > + ${CHMOD} 0 /usr/bin/mailq.OFF; \
> > + fi
> > + @if [ -e ${PREFIX}/bin/qmail-qread ]; then \
> > + ${LN} -s ${PREFIX}/bin/qmail-qread /usr/bin/mailq; \
> > + fi
> > + @${ECHO_MSG} "===> Replacing newaliases"
> > + @if [ -e /usr/bin/newaliases ]; then \
> > + ${MV} -f /usr/bin/newaliases /usr/bin/newaliases.OFF && \
> > + ${CHMOD} 0 /usr/bin/newaliases.OFF; \
> > + fi
> > + @if [ -e ${PREFIX}/bin/newaliases ]; then \
> > + ${LN} -s ${PREFIX}/bin/newaliases /usr/bin/newaliases; \
> > + fi
>
> I don't like this hackery for the non-mailwrapper case. People who have
> mailwrapper may call it, which would really suck. I'd prefer the
> copious warnings, or just a quick description in the
> documentation/porting notes.
That's why it is not documented, nor shown, not pkg/MESSAGEd
to the user unless the port can not find any mailer.conf. I could
add a check not allowing the aforementioned if I could find a
mailer.conf but; then, someone could find a particular good reason
to allow it even when you have a valid mailer.conf.
I provide proper documentation telling how to either add your
own mailer.conf or remove sendmail replacing it with qmail binaries.
Not to mention, example files.
On the enable-qmail target I warn the user quite effectivily
to be very afraid before running a force-enable-qmail. Besides,
if one found out about force-enable-qmail then one must have read
the Makefile and ignored any other lines. If one shot one's own
foot, who is to blame? If one does not understand what one is doing
at all, then WTH is one doing?
Futhermore, we can not hold everyone's hands. If we try
to do so, work won't get done. I am trying to reliably hold their
hands as much as possible. If you think more can be done, suggest
a better way and I'll try to do it. Or better yet, you could send
in patches. :-)
I am sure we can provide better anti-shoot protection, but
to what extent and to what cost. I am open to suggestions, but I
am saying this is good and better than before.
Regards,
Mario Ferreira
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000624155202.A22523>