From owner-svn-src-all@freebsd.org Fri Aug 2 10:47:52 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F85EAFAE9; Fri, 2 Aug 2019 10:47:52 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 460P536x20z3wfW; Fri, 2 Aug 2019 10:47:51 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id E2E0F43E304; Fri, 2 Aug 2019 20:47:45 +1000 (AEST) Date: Fri, 2 Aug 2019 20:47:44 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: "Bjoern A. Zeeb" cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350532 - head/sys/netinet6 In-Reply-To: <201908021006.x72A6smN041745@repo.freebsd.org> Message-ID: <20190802203707.S1343@besplex.bde.org> References: <201908021006.x72A6smN041745@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 cx=a_idp_d a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=YjTnG6WotgYSgN7JHBkA:9 a=CjuIK1q_8ugA:10 X-Rspamd-Queue-Id: 460P536x20z3wfW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.87 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.87)[-0.873,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Aug 2019 10:47:52 -0000 On Fri, 2 Aug 2019, Bjoern A. Zeeb wrote: > Log: > frag6.c: sort includes > > Sort includes and remove duplicate kernel.h as well as the unneeded > systm.h. sys/systm.h is always needed, since it defines macros and functions which might be needed in other headers. frag6.c even uses KASSERT() directly. > Modified: head/sys/netinet6/frag6.c > ============================================================================== > --- head/sys/netinet6/frag6.c Fri Aug 2 07:41:36 2019 (r350531) > +++ head/sys/netinet6/frag6.c Fri Aug 2 10:06:54 2019 (r350532) > @@ -37,18 +37,16 @@ __FBSDID("$FreeBSD$"); > #include "opt_rss.h" > > #include > -#include This was correct. sys/systm.h must also be included in this order. Now the KASSERT() used in frag6.c is apparently obtained via pollution in some other header. > -#include > -#include > -#include > #include > +#include sys/errno is standard pollution in sys/param.h (if _KERNEL). It is a style bug to not depend on this. > #include > +#include > #include > +#include sys/malloc.h is polluted by including sys/systm.h. > +#include sys/mbuf.h is polluted by including sys/systm.h. > #include > #include > -#include > #include sys/time.h is standard pollution in sys/param.h (if _KERNEL). It is a style bug to not depend on this. > -#include > #include > > #include machine/atomic.h is standard non-pollution on sys/systm.h. It is a style bug to include it directly. Bruce