From owner-svn-src-head@freebsd.org Wed Jun 20 16:38:25 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DD3610232D8; Wed, 20 Jun 2018 16:38:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B64483C7A; Wed, 20 Jun 2018 16:38:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTP id w5KGc8pg026443; Wed, 20 Jun 2018 19:38:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w5KGc8pg026443 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w5KGc8nK026442; Wed, 20 Jun 2018 19:38:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 20 Jun 2018 19:38:07 +0300 From: Konstantin Belousov To: Warner Losh Cc: Ian Lepore , Allan Jude , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335276 - in head/stand/i386: gptboot zfsboot Message-ID: <20180620163807.GP2430@kib.kiev.ua> References: <201806170318.w5H3IvJP090557@repo.freebsd.org> <5B2646B3.4020200@grosbein.net> <93b03eb5-326b-5df1-5d41-ae3da163e894@freebsd.org> <20180620092238.GK2430@kib.kiev.ua> <1529509411.20460.83.camel@freebsd.org> <20180620160315.GO2430@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 16:38:25 -0000 On Wed, Jun 20, 2018 at 10:05:16AM -0600, Warner Losh wrote: > On Wed, Jun 20, 2018 at 10:03 AM, Konstantin Belousov > wrote: > > > On Wed, Jun 20, 2018 at 09:43:31AM -0600, Ian Lepore wrote: > > > On Wed, 2018-06-20 at 12:22 +0300, Konstantin Belousov wrote: > > > > On Tue, Jun 19, 2018 at 08:34:18PM -0400, Allan Jude wrote: > > > > > > > > > > On 2018-06-17 07:32, Eugene Grosbein wrote: > > > > > > > > > > > > 17.06.2018 10:18, Allan Jude wrote: > > > > > > > > > > > > > > > > > > > > Author: allanjude > > > > > > > Date: Sun Jun 17 03:18:56 2018 > > > > > > > New Revision: 335276 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/335276 > > > > > > > > > > > > > > Log: > > > > > > > gptboot, zfsboot, gptzfsboot: Enable the video and serial > > consoles early > > > > > > > > > > > > > > Normally the serial console is not enabled until /boot.config > > is read and > > > > > > > we know how the serial console should be > > configured. Initialize the > > > > > > > consoles early in 'dual' mode (serial & keyboard) with a > > default serial > > > > > > > rate of 115200. Then serial is re-initialized once the disk is > > decrypted > > > > > > > and the /boot.config file can be read. > > > > > > > > > > > > > > This allows the GELIBoot passphrase to be provided via the > > serial console. > > > > > > > > > > > > > > PR: 221526 > > > > > > > Requested by: many > > > > > > > Reviewed by: imp > > > > > > > Sponsored by: Klara Systems > > > > > > > Differential Revision: https://reviews.freebsd.org/D15862 > > > > > > I had several cases when booting FreeBSD/amd64 with motherboard > > having no serial ports > > > > > > hang hard early at boot unless I rebuilt boot media configuring it > > to NOT try accessing > > > > > > missing serial ports. I even could reproduce that with VirtualBox > > machine configured > > > > > > with no serial ports (not same as existing bug inactive serial > > port). > > > > > > > > > > > > Should there be some way to disable this serial ports > > configuration at compile time? > > > > > > > > > > > > > > > > > > > > > > > I think what we'll do it compile it both ways, and use the non-serial > > > > > one by default, because it is safer. Then you can just use > > > > > 'gptboot-serial' if you want serial support. > > > > > > > > > > This will likely make Warner a bit sad, since we are just finally > > > > > getting around to reducing the number of different bootcode files. > > > > I think we should follow the hardware trends there and apply a policy > > > > where new features are not added to the CSM boot. All modern machines > > > > can be booted in UEFI mode, and if some modern machine cannot, then we > > > > need it fixed. We should encourage users to make new installs boot by > > > > UEFI. > > > > > > > > The feature from the commit is only relevant for machines that require > > > > CSM boot or do not have UEFI option at all, am I right ? With the > > policy > > > > applied, an additional CSM-boot bootblock would be not shipped. > > > > > > > > > > I think it is far too early to say that the code for booting without > > > efi is abandonware. I have half a dozen x86 boxes in use here, and only > > > one of them is even able to boot efi, and its default resolution in efi > > > mode confuses the kvm switch it's connected to, so even on that I have > > > to use legacy bios boot. > > I do not propose to abandon bios boot, or even to declare it legacy > > with the proper meaning. I mean that CSM is disappearing on the newest > > platforms, and should become only used on old machines or i386. With that > > attitude, adding a features for it, esp. by the cost of the user confusion, > > is not worth the efforts. It still should be maintained for the foreseable > > future. > > > > If the machines where you get the trouble is newer than say 5 years, > > then they should boot with UEFI. If not, the problem in loader.efi > > needs to be fixed. > > > > There is no problem in loader.efi that's specific to geli. It already uses > the UEFI boot loader config. While there's some issues downstream (eg > kernel messages), this specific issue is a non-issue for loader.efi. I referenced the problems that Ian has with UEFI boot on his machines, not the serial console and geli change above.